Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code generation fix: Specifying new values for existing enums in a separate file might overwrite existing ones #480

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Code generation fix: Specifying new values for existing enums in a separate file might overwrite existing ones #480

merged 1 commit into from
Jul 31, 2024

Conversation

florianessl
Copy link
Member

Easily reproducible by introducing new values in easyrpg_fields.csv:

EventPage,Trigger,map_init_deferred,8
EventPage,Trigger,map_init_immediate,9

Depends on order though. I defined these values at line 35, right before the Maniac stuff:
EventPage,ManiacEventInfo,*

@florianessl
Fixed issue in code generator: merging enums from two different files…
afe471d 
… might overwrite existing declarations in some cases
@fdelapena fdelapena requested a review from Ghabry July 13, 2024 01:36
@Ghabry Ghabry added this to the 0.8.1 milestone Jul 31, 2024
@Ghabry Ghabry merged commit 505496c into EasyRPG:master Jul 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carstene1ns carstene1ns carstene1ns approved these changes

@fdelapena fdelapena fdelapena approved these changes

@Ghabry Ghabry Awaiting requested review from Ghabry

Assignees
No one assigned
Labels
None yet
Milestone
0.8.1
Development

Successfully merging this pull request may close these issues.
4 participants
@florianessl @fdelapena @carstene1ns @Ghabry