Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip unknown fields #182

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

dbardbar
Copy link
Contributor

@dbardbar dbardbar commented Jan 9, 2023

Solves issue #181

@dbardbar
Copy link
Contributor Author

dbardbar commented Feb 9, 2023

@akshah - following our conversation - the diff tool got a bit confused because I moved things around a bit. But basically, we now first read the bytes, and then check if the type is known. If known, then parse it. If not known, then either stop processing or ignore it, depending on the flag. If things are still not clear, let's talk.

@dbardbar
Copy link
Contributor Author

@akshah - any news on this? Did you look at this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant