retire Ruby 2 + gems update + release 1.6 #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| working_directory: ~/repo | ||
| steps: | ||
| - build | ||
|
|
There was a problem hiding this comment.
@thomasLeclaire do you know why this "build_2_x" step still appears in GitHub ? It's gone on CircleCI but still blocks validation on GitHub
Same on this simpler PR #92
There was a problem hiding this comment.
it is the branches protections : defined there https://github.com/Effilab/bing_ads_ruby_sdk/settings/branch_protection_rules/4793994
just removed the 2.x one.
|
You should consider to publish explicitly a new gem and change the ruby_version there : (and maybe review also the other dependency in same file)and adapt the changelog obviously. this gem is public and used out of solocal fyi. |
danielmbarlow
approved these changes
Sep 14, 2023
tdutreui-solocal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.7 life ended 5 months ago (31 Mar 2023)