codeql vulnerability #1 fix #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmbarlow
approved these changes
Sep 14, 2023
| @@ -7,6 +7,8 @@ def self.camelize(string) | |||
| end | |||
|
|
|||
| def self.snakize(string) | |||
| raise "Unexpected string length : #{string.length} for string '#{string[0..200]}...'" if string.length > 1000 | |||
There was a problem hiding this comment.
we are expecting hash keys and classnames only
There was a problem hiding this comment.
Suggested change
| raise "Unexpected string length : #{string.length} for string '#{string[0..200]}...'" if string.length > 1000 | |
| raise "Unexpected string length : #{string.length} for string '#{string[0..200]}...'" if string.length > 200 |
I doubt we'll be dealing with strings longer than 200 characters anyway, will we?
There was a problem hiding this comment.
OK looks like we might have strings that can be quite long, so whatever you think.
There was a problem hiding this comment.
Error names for example could be long :
Example : CampaignServiceNegativeKeywordListWithActiveAssociationsCannotBeDeleted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes https://github.com/Effilab/bing_ads_ruby_sdk/security/code-scanning/1
fixes https://github.com/Effilab/bing_ads_ruby_sdk/security/code-scanning/2