Pin blinker to version <1.8 as fix for #329. #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As PyleniumIO relies on selenium-wire (which is no longer alive) and this project again on blinker one would like to pin it to a working version. seleium-wire uses a private method of blinker which has been removed in the 1.8 release. As selenium-wire cannot be changed the only way is to pin blinker.
|
You've raised really good points! It's probably best to remove |
|
Yes I agree. Removing the |
|
I'm closing this as we've now removed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As PyleniumIO relies on
selenium-wire(which is no longer alive/maintained) and this project again usesblinkerone would like to pin this "stack" to a working version.selenium-wirein it's final version uses a private method of blinker which has been removed in the 1.8 release. As selenium-wire cannot be changed the only way is to pin blinker.