-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies. test against symfony 7 #227
Conversation
I am sorry, I dont have the time nor energy to work on this.. I assumed itd be a simple fix. But there are many changes in Doctrine as well as in symfony, tests are therefore failing. |
No problem, thanks @michnovka for trying. Keeping opened for reminder. |
@ogizanagi Have a look at the errors tho. What buffles me most is that ini_set error. Then we have another issue - doctrine since orm 2.17. requires some config params report_fields_where_declared: true
enable_lazy_ghost_objects: true and throws deprecation when not present. So with "lowest deps" option we need to use different config for symfony than for all the others (which default to 2.17 version as of now). The mongodb installation on windows is totally broken, but id look into this as latest. |
I made some progress, but we have an issue still. There are multiple config conflicts we need to address depending on which CI job is run (which Symfony/Doctrine version) One is the aforementioned report_fields_where_declared: true
enable_lazy_ghost_objects: true That stems from DoctrineBundle version < 2.10 cannot parse the config. And if we do bump the bundle, we still need to keep these values as FALSE for orm < 2.14, as it is not supported. So we need 2 different config files for then in Symfony 7.x annotation routing was removed, so we also need 2 versions of I dont know how to do this, so @ogizanagi if you have an idea, or preferably if you build on my findings I will appreciate any help. I dont get AT ALL why symfony 6.x has the ini_set errors. And also still totally unsure why Windows mongodb install suddenly fails, I didnt make changes there. |
Update - I followed symfony/symfony#51600 (no idea why this is needed, but it does work) and now symfony 6.3 works well. We still have tons of deprecations issues in 6.4 and 7.x does not work at all. We need separate configs based on the symfony version used |
My OCD will kill me one day... Cant leave a draft PR. Anyways, I am happy with it, please review @ogizanagi |
tests/Fixtures/Integration/Symfony/config/config-routing-annotation.yaml
Outdated
Show resolved
Hide resolved
tests/Fixtures/Integration/Symfony/config/config-routing-attribute.yaml
Outdated
Show resolved
Hide resolved
.../Integration/Symfony/src/ControllerAnnotation/QueryBodyBackedEnumValueResolverController.php
Show resolved
Hide resolved
do you want me to squash commits? |
@michnovka yes, please 🙏🏻 |
b0c6675
to
572f0d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, thank you very much @michnovka 🙏🏻
Update tests and check against versions that are not EOL:
https://endoflife.date/symfony