Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DBAL4 changes #232

Merged
merged 2 commits into from
Jun 7, 2024
Merged

DBAL4 changes #232

merged 2 commits into from
Jun 7, 2024

Conversation

michnovka
Copy link
Contributor

Supersedes #228

@michnovka
Copy link
Contributor Author

Hi @ogizanagi , I have made a version which should allow us to use Doctrine 3 and DBAL 4 without the need to explicitly maintain 2 versions.

I do have some PHPStan issues because of that, as I had to use some code dynamically based on class_exists to differentiate between DBAL3 and DBAL4. I am not experienced with PHPStan exceptions, so can you please take it up from here, create these exceptions (as these errors are expected) and review my code?

Thanks!

@ogizanagi
Copy link
Member

@michnovka : that's awesome 💖 and a weird coincidence ; I was about to start this exactly today. So thank you very much for saving me this work and I'll look at it in the next days 🙏🏻

@ogizanagi ogizanagi self-assigned this Jun 5, 2024
@ogizanagi ogizanagi force-pushed the 2.x-dbal4 branch 2 times, most recently from 67d3b6c to ee5e0f0 Compare June 7, 2024 13:48
@ogizanagi
Copy link
Member

Thanks @michnovka.

@ogizanagi ogizanagi merged commit 503a7fb into Elao:2.x Jun 7, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants