Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict broken DBAL 4 versions #235

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Conflict broken DBAL 4 versions #235

merged 1 commit into from
Oct 16, 2024

Conversation

michnovka
Copy link
Contributor

Fixes #234

@michnovka
Copy link
Contributor Author

Hmm, so we have 2 failed tests, separate issues:

  1. the lowest deps installs symfony/var-exporter (v4.4.11) and the error says:
LogicException: Lazy ghost objects cannot be enabled because the "symfony/var-exporter" library version 6.2 or higher is not installed. Please run "composer require symfony/var-exporter:^6.2".

I want to investigate that.

  1. PHP 8.4 fails due to PHPUnit's incompatibility with PHP8.4 Id say (there are deprecations), I think safe to ignore

@michnovka
Copy link
Contributor Author

Ok, I think this can be merged. The php 8.4 failed test cant be fixed until we use phpunit 11, and unfortunately thats not compatible with symfony phpunit bridge.
I think the future of this bridge is doomed anyways, so at one point well have to use native phpunit without bridge, but lets see. For now I am done. @ogizanagi please review

@ogizanagi
Copy link
Member

Thanks @michnovka.

@ogizanagi ogizanagi merged commit 25382e9 into Elao:2.x Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump DBAL 4 min version to 4.2.0
2 participants