Monitor channels job #242
Merged
Monitor channels job #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daliclovr
reviewed
Jul 24, 2023
daliclovr
reviewed
Jul 24, 2023
daliclovr
reviewed
Jul 24, 2023
daliclovr
reviewed
Jul 24, 2023
daliclovr
requested changes
Jul 24, 2023
RodriFS
commented
Jul 24, 2023
Jossec101
reviewed
Jul 25, 2023
|
This PR needs thorough testing imo |
|
Added unit testing |
Jossec101
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Lets use gRPC client factory by MSFT to have a good way to use gRPC channels efficiently:
https://learn.microsoft.com/en-us/aspnet/core/grpc/clientfactory?view=aspnetcore-7.0
daliclovr
previously approved these changes
Jul 27, 2023
Jossec101
approved these changes
Jul 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The idea for this PR is to be able to check for and add ghost channels to the NodeGuard