Update tests #26
Draft
Update tests #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RahulJain28
commented
Mar 14, 2023
RahulJain28
commented
- Change cargo toml before merging
- builds off dev
Draft implementation of time-in-force (TIF) orders for Phoenix v1. Added a standard test in test_market.rs. Could use more coverage Changes: - Uses the padding on the FIFORestingOrder to store and expiration slot and an expiration time - Modifies the OrderPacket struct to enable specification of expiration - Injects logic into the matching engine to skip orders that are expired
Changes: - DecrementTake handles partial removals - Free fund accounting now occurs after the matching/order placement to ensure that checks work as intended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.