This repository has been archived by the owner on May 25, 2020. It is now read-only.
Binding fixes #24
Open
Binding fixes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update eolian_cxx tests in order to remove forbidden eolian notations. For tests with containers that support non-pointer types, change `ptr(int)` to `int`. For tests with containers that only support pointer types, change `ptr(int)` to `string`. Remove tests for features that are no longer meaningful with eolian new restrictions. Add a FIXME note to eina::range_array when used with eina::string_view.
Update eolian_cxx to recognize the new keywords `slice` and `rw_slice`, so it can generate the corresponding types `Eina_Slice` and `Eina_Rw_Slice`.
…keywords Add support for `slice` and `rw_slice` keywords in eolian_mono. Now it generates the proper manual binding type for these native types. Make unit tests use these keywords instead of native names. Remove some unnecessary `@beta` tags from eolian types in unit tests so now tests correctly compile without the `mono-beta` compilation flag. Also make tests that use `Eina.Binbuf` "beta only". In a future update, the external type `Eina.Binbuf` will be marked as beta, so we shield the binding in anticipation.
…cumentation Some parameter names, tag names and cref identifiers in the documentation were incorrect and causing warnings during compilation. There were also warnings related with missing documentation in publicly visible elements in the manual binding. This commit fixes these incorrections and adds documentation to the manual binding in order to solve these compilation warnings. Warnings related with missing documentation in `.eo` files are still present.
Fix some warnings in the C++ examples for elementary. These examples are build by default in the normal meson compilation. Only accidental warnings were fixed, explicit warnings using the `#warning` preprocessor directive were maintained.
segfaultxavi
suggested changes
Jul 7, 2019
|
Hmmm... I just wanted to approve the commits regarding C# warnings, not the whole PR. The Eolian-related fixes will need @q66 I guess. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation for future eolian restrictions and warning fixes.