unsubscribe listenToChanges firestore

[snehmehta]

ticket: #1468

Issue:
Conditional will rebuilt it's children from scratch on data changes, so tabbar will always be created new and have index 0.

Solution:
Unsubscribe to changes onTab change and resubscribe to changes when needed again.

View:
  styles:
    useSafeArea: true

  header:
    titleText: Tab issue
  

  onLoad: 
    invokeAPI:
      name: getUsers
      inputs:
        listen: true
      

  body:
    Column:
      styles:
        padding: 24
        gap: 8
      children:
        - Conditional:
            conditions:
              - if: ${ensemble.storage.data != null}
                widget:
                  TabBar:
                    id: liveTabBar
                    styles:
                      tabAlignment: center
                    onTabSelection:
                      executeConditionalAction:
                        conditions:
                          - if: ${liveTabBar.selectedIndex != 0}
                            action: 
                              invokeAPI:
                                name: getUsers
                                inputs: 
                                  listen: false
                          - else:
                            action:
                              invokeAPI:
                                name: getUsers
                                inputs: 
                                  listen: true

                    items:
                      - label: Hello
                        widget:
                          Event:
                            inputs:
                              data: ${ensemble.storage.data}
                      - label: world
                        widget: 
                          Text:
                            text: world

Event:
  inputs:
    - data
  body:
    Text:
      text: ${data}


API:
  getUsers:
    inputs:
      - listen
    type: firestore
    path: matches
    onResponse:
      executeCode:
        body: |-
          ensemble.storage.data = response.body.documents[0].data;
    listenForChanges: listen

[kmahmood74]

we need to consider the API's with the same name but different IDs. The use case there is calling the same API with different inputs and using the API's id to bind it to different widgets. This code will cancel subscriptions for any existing APIs with the same name but different ids

[snehmehta]

I agree. I'll implement once I prioritise it.

[kmahmood74]

@snehmehta any update on this, this has been pending since July which means we still have this issue?

[kmahmood74]

@snehmehta any update on this?