BAR-29: Minor AWS snapshot fixes #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds tests for unsupported cloud providers when creating a CloudSnapshotInterface. These were originally covered by the `aws` provider but since this is now supported we need the additional test cases in this commit to cover the handling unsupported providers.
Uses the region set in the `snapshots_info/provider` section of the backup_info when creating an `AwsCloudSnapshotInterface` from a backup_info. This does not take precedence over the region specified in the config, so it is possible for the user to force a different region to be used at recovery or deletion time.
Fixes a number of typos and inaccuracies in comments in the unit tests.
Adds a note to the manual explaining that either IDs or names can be used when specifying instances or volumes in AWS.
mikewallace1979
force-pushed
the
BAR-29-minor-aws-snapshot-fixes
branch
from
defdc5c
to
a012ccd
Compare
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues identified by the integration tests for AWS snapshot backups.