Add doc about keep restriction on incremental backups #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcalacoci
reviewed
Aug 14, 2024
The use of keep annotations should be restricted to full backups only as it could lead to having orphan backups in a case where a Postgres incremental backup has its parent deleted while having the keep annotation. Such an incremental backup will then be useless for recovery. References: BAR-258 Signed-off-by: Andre <[email protected]>
barthisrael
requested changes
Aug 19, 2024
gcalacoci
approved these changes
Aug 19, 2024
|
Let's squash this, so we can merge. |
andremagui
force-pushed
the
dev/bar-258
branch
from
119c4f5
to
aadf28a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of keep annotations should be restricted to full backups only as it could lead to having orphan backups in a case where a Postgres incremental backup has its parent deleted while having the keep annotation. Such an incremental backup will then be useless for recovery.
This PR is adding a note to the documentation of the barman
keepcommandReferences: BAR-258