Add docs about the new keep-alive mechanism #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcalacoci
approved these changes
Aug 19, 2024
|
this LGTM, approved. |
barthisrael
requested changes
Aug 19, 2024
There was a problem hiding this comment.
The changes introduced by this PR look good.
I'm only missing some "note" in the Backup with rsync/SSH section providing more context about this setting. Maybe something like this:
> **NOTE:**
> Starting with Barman 3.11.0, Barman uses a keep-alive mechanism when taking
> rsync-based backups. It keeps sending a simple `SELECT 1` query over the
> libpq connection where Barman runs `pg_backup_start`/`pg_backup_stop`
> low-level API functions, and it's in place to reduce the probability of a firewall or
> a router dropping that connection as it can be idle for a long time while the base
> backup is being copied. You can control the interval of the hearbeats, or even
> disable the mechanism, through the `keepalive_interval` configuration option.Thoughts @gcalacoci @gustabowill ?
LGTM |
Add in the docs a description of the new `keepalive_interval` server configuration as well as your equivalent CLI argument `--keepalive-interval` that can be specifided together with the `backup` command. References: BAR-256 Signed-off-by: Gustavo William <[email protected]>
gustabowill
force-pushed
the
dev/bar-256
branch
from
5068648
to
7fd1c72
Compare
Looks awesome, thanks! I added that at the end of the Rsync section. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add in the docs a description of the new
keepalive_intervalserver configuration as well as your equivalent CLI argument--keepalive-intervalthat can be specifided together with thebackupcommand.References: BAR-256