Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change docs to introduce the new --incremental option #992

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Change docs to introduce the new --incremental option #992

merged 1 commit into from
Aug 22, 2024

Conversation

gustabowill
Copy link
Contributor

Change docs to explain the new --incremental option that can be used together with the backup command. Some sections which mentioned incremental backups are being something specific to Rsync were also changed to take the new block-level incremental option into account.

References: BAR-249

@gustabowill gustabowill marked this pull request as ready for review August 19, 2024 10:57
@gustabowill gustabowill requested a review from a team as a code owner August 19, 2024 10:57
@gustabowill gustabowill self-assigned this Aug 19, 2024
@gustabowill gustabowill force-pushed the dev/bar-249 branch 5 times, most recently from 00b539a to 02f07da Compare August 19, 2024 12:15
barthisrael
barthisrael reviewed Aug 19, 2024
View reviewed changes
Copy link
Contributor

@barthisrael barthisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be cool to merge the other PRs first, which are smaller, so we can rebase this on top of the new master branch.
That way we can build a new document and go over it as a whole.

gcalacoci
gcalacoci approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@gcalacoci gcalacoci left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DALL·E 2024-08-20 16 40 29 - A round badge-like image with a cartoonish seal in the center The seal should have a cute and playful appearance, with large round eyes, a smiling fa

Writing LGTM was starting to be boring....

barthisrael
barthisrael requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@barthisrael barthisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the changes introduced by this PR.
I think we can leverage of them to add a note to the rsync section.

doc/manual/50-feature-details.en.md Show resolved Hide resolved
@gustabowill gustabowill force-pushed the dev/bar-249 branch 3 times, most recently from 98948f3 to 4c3064d Compare August 21, 2024 19:55
martinmarques
martinmarques requested changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@martinmarques martinmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes to perform. Overall this looks great!

doc/barman.1.d/50-backup.md Outdated Show resolved Hide resolved
doc/manual/50-feature-details.en.md Outdated Show resolved Hide resolved
doc/manual/50-feature-details.en.md Show resolved Hide resolved
doc/manual/50-feature-details.en.md Outdated Show resolved Hide resolved
barthisrael
barthisrael reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@barthisrael barthisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!
I think after applying Martin's suggestions we are good.
I posted another suggestion just expanding on your note.

doc/manual/50-feature-details.en.md Outdated Show resolved Hide resolved
@gustabowill
Change docs to introduce the new --incremental option
89a7573 
Change docs to explain the new `--incremental` option that can be used
together with the `backup` command. Some sections which mentioned
incremental backups are being something specific to Rsync were also
changed to take the new block-level incremental option into account.

References: BAR-249

Signed-off-by: Gustavo William <[email protected]>
barthisrael
barthisrael approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@barthisrael barthisrael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gustabowill
Copy link
Contributor Author

Just finished applying all suggestions.

@barthisrael barthisrael merged commit bfaddd4 into master Aug 22, 2024
7 of 8 checks passed
@barthisrael barthisrael deleted the dev/bar-249 branch August 22, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmarques martinmarques martinmarques requested changes

@barthisrael barthisrael barthisrael approved these changes

@gcalacoci gcalacoci gcalacoci approved these changes

Assignees

@gustabowill gustabowill

Labels
docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gustabowill @gcalacoci @martinmarques @barthisrael