Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing for datacard deletion #621

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Conversation

HyunjunA
Copy link
Contributor

@HyunjunA HyunjunA commented Oct 2, 2023

No description provided.

@jay-m-dev
Copy link
Contributor

I checked out this commit got the HTTP 500 error message.
These were my steps

  1. Uploaded a csv
  2. Enabled the AI button
  3. Clicked the "delete icon" while the first experiment was running
  4. the dataset was deleted by the DELETE endpoint

Step 4 means that experiments were not recognized as 'running'. Maybe there's a split second where an experiment is finished and a new experiment is about to start (at this point in time it's possible there are no 'running' experiments).

Checking if the AI button is 'on' instead of checking if experiments are 'running' may work here. But this wouldn't handle cases where an experiment is launched manually, and then the user attempts to delete the dataset.

I'm going to try checking for both (the status of the AI and if experiments are 'runing') on the DELETE endpoint.

@jay-m-dev jay-m-dev linked an issue Oct 2, 2023 that may be closed by this pull request
@jay-m-dev
Copy link
Contributor

Added a check for the recommender status in PR #622. @HyunjunA Could you please update your branch with the latest EpistasisLab/Aliro master branch so we can test this PR again?

@jay-m-dev jay-m-dev added this to the v0.21 milestone Oct 3, 2023
@jay-m-dev
Copy link
Contributor

After the update from master (commit 6b27b4e) the issue is partially resolved.
The alert saying "dataset cannot be deleted" now pops up if the ai button is enabled. But still fails if an experiment is running manually.
Since this PR adds frontend code and seems to work fine. I'm merging it and will troubleshoot issue #197 from master.

@jay-m-dev jay-m-dev merged commit d31cc68 into EpistasisLab:master Oct 4, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants