Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fixes #109

Merged
merged 1 commit into from
Nov 3, 2023
Merged

bug fixes #109

merged 1 commit into from
Nov 3, 2023

Conversation

perib
Copy link
Collaborator

@perib perib commented Nov 3, 2023

fixed an issue where the old_params in the individual's NodeLabel were not being reset when a new method was selected. Previous solution tried to update the parameters of the old node. This version creates an entirely new node and replaces the old node in the graph.

Also fixed an issue where we could not set both inner_config_dict and leaf_config_dict to None. When mutate_insert_leaf tried to add a leaf, an error was thrown. Now this mutation function is not a possible option unless one of the inner or leaf config dictionaries is set.

I tested this with a configuration dictionary that includes only xgboost and sgdcclassifier since they share a parameter name with different types, which would cause errors in the hyperparamter update function.

from xgboost import XGBClassifier
from sklearn.linear_model import SGDClassifier
from tpot2.config.classifiers import params_SGDClassifier, params_XGBClassifier

root_config_dict =  {SGDClassifier : params_SGDClassifier,
                     XGBClassifier : params_XGBClassifier,}

@perib perib marked this pull request as ready for review November 3, 2023 19:18
@perib perib merged commit f298771 into EpistasisLab:dev Nov 3, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant