Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update tiktoken to 0.8 to support py3.13 build #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 commented Oct 15, 2024

update tiktoken to 0.8 to support py3.13 build

tiktoken 0.8.0 changelog notes, https://github.com/openai/tiktoken/blob/main/CHANGELOG.md#v080

relates to Homebrew/homebrew-core#194427

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to ed914c7 in 11 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. pyproject.toml:26
  • Draft comment:
    Ensure compatibility with tiktoken 0.8.0 by reviewing its changelog for any breaking changes or necessary adjustments in the codebase.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The PR updates the tiktoken dependency from version 0.7 to 0.8. This change is straightforward and aligns with the PR description, which mentions the need to support Python 3.13 builds. The changelog for tiktoken 0.8.0 should be reviewed to ensure compatibility and no breaking changes, but this is not part of the code review process. The rest of the pyproject.toml file remains unchanged, which is expected for this PR.

Workflow ID: wflow_cgK4lgsHfKzKEpWN


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@chenrui333
Copy link
Author

actually also need huggingface/tokenizers#1639

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant