Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an exception for extendedFieldName #763

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add an exception for extendedFieldName #763

wants to merge 3 commits into from

Conversation

Mr14huashao
Copy link

Add a test case about boolean field for #699

@Mr14huashao Mr14huashao mentioned this pull request Aug 29, 2020
Closed
@theigl
Copy link
Collaborator

theigl commented Aug 30, 2020

@Mr14huashao: As I said in #759, we need a solution with minimal overhead. Ideally, the duplicate field check would be done only once when the serializer is first initialized. I think we should only log a warning so we do not break existing applications and force them to use extendedFieldNames.

@Mr14huashao
Copy link
Author

@theigl Thank you for checking my code.
Based on the suggestion you provided, I modified some code, and the code is better.
I've benefited a lot from it.
Thank you very much.

theigl
theigl requested changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@theigl theigl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mr14huashao: Sorry for the delay. I just reviewed your PR.

Please adjust your tests to use existing support from KryoTestCase and change your tests to look like others in the same file.

test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated Show resolved Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated Show resolved Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated Show resolved Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated Show resolved Hide resolved
test/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializerTest.java Outdated Show resolved Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated Show resolved Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated Show resolved Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated Show resolved Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated Show resolved Hide resolved
src/com/esotericsoftware/kryo/serializers/CompatibleFieldSerializer.java Outdated Show resolved Hide resolved
@Mr14huashao Mr14huashao mentioned this pull request Sep 19, 2020
Closed
@theigl
Copy link
Collaborator

theigl commented Nov 2, 2020

@Mr14huashao: I'm currently trying to stabilize Kryo 5.0.0 and will merge only bug fix PRs in the near future. Let's revisit this after Kryo 5.0.1 has been released.

@Mr14huashao
Copy link
Author

@theigl Do I want to modify some content based on the current version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theigl theigl Awaiting requested review from theigl

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mr14huashao @theigl