Doppio benchmarking merge #1520

elliedavidson · 2023-08-07T19:56:45Z

This PR merges in changes made while benchmarking, including:

Update examples to submit transactions on each view change event
Update examples so only the last 10 nodes of the network submit transactions
Update DA task so that only DA members poll for DA proposals
Fix bug where PollForTransaction tasks were not getting properly canceled
Update orchestrator to properly set up small DA committees

This PR does not:

Fix any stylistic errors other than clippy errors.

…to handle more than 1 tx at a time

…from webserver

Ed/batch transactions

…pio_benchmarking

bfish713 · 2023-08-07T20:21:50Z

src/traits/networking/web_server_network.rs

-                }
-            }
-        });
+        // let tx_handle = async_spawn({


Nit: Remove

shenkeyao

LGTM

elliedavidson and others added 30 commits July 21, 2023 14:59

Update error logging for num tx decided

26427fa

update example tx accounting

bb8c423

Update finish run logging

0ab6cea

More error logging in network task

7a6e0d2

logging

a34bb6c

fewer ws transactions in memory

b1dd921

make nodes submit tx each round in example

faecedd

gen more transactions

607dc2e

gen more transactions

d1da23e

Move where tx are submitted

d0409f7

Make DA committee configurable

b0dabea

update modDA.rs to handle different committee sizes

7c90cb7

Updated web server and node web server, need to update network event …

df9ed32

…to handle more than 1 tx at a time

Update examples to use 2 web servers instead of 3

c7eb212

Transaction polling only for previous views, endpoint to remove txns …

4aa7a97

…from webserver

Merge

722e961

Blocks now have txs in them, still need to update with batch size

3b43b77

Merge pull request #1431 from EspressoSystems/ed/batch_transactions

c118d7f

Ed/batch transactions

Merge remote-tracking branch 'origin/bf/transaction-polling' into dop…

cf6deae

…pio_benchmarking

Use batch size

e4f6c7e

Update inject event for transactions

ec7f181

Batch size is 1

1e0a3a1

more error logging

c24f3dd

change where we cancel pollfortransactions

9c793fc

update example for how often to submit txs

4fd960d

merge with run view refactor

2415331

Update num_block to block_size

12c8ff1

update infra.rs

23fa9af

Fix div by zero

70ffa80

Fix div by zero

979b031

elliedavidson added 14 commits August 2, 2023 07:56

update max txns

29a17e2

more ws updates

47100e0

Fix several bugs in tx polling

b789642

Back to regular leader function

be3ed63

update tx submission

3c3b8a6

Reduce logging levels

2a2f419

Reduce logging levels

d628581

Reduce logging levels

c050d0f

Merge with main

48b6e5e

Clean up compile errors from merge

7b675a7

fmt

d1db810

Fix warnings

5491217

Clippy and fmt fixes

065fbe6

Updates

27d65c6

elliedavidson requested review from kmchicoine, shenkeyao, DieracDelta, bfish713 and dailinsubjam and removed request for kmchicoine and shenkeyao August 7, 2023 20:04

bfish713 previously approved these changes Aug 7, 2023

View reviewed changes

Address comments

c23eb15

elliedavidson dismissed bfish713’s stale review via c23eb15 August 7, 2023 20:25

bfish713 approved these changes Aug 7, 2023

View reviewed changes

shenkeyao approved these changes Aug 7, 2023

View reviewed changes

elliedavidson merged commit 5b102e7 into main Aug 7, 2023
6 of 7 checks passed

elliedavidson deleted the doppio_benchmarking_merge branch August 7, 2023 20:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Doppio benchmarking merge #1520

Doppio benchmarking merge #1520

elliedavidson commented Aug 7, 2023 •

edited

Loading

bfish713 Aug 7, 2023

shenkeyao left a comment

Doppio benchmarking merge #1520

Doppio benchmarking merge #1520

Conversation

elliedavidson commented Aug 7, 2023 • edited Loading

bfish713 Aug 7, 2023

Choose a reason for hiding this comment

shenkeyao left a comment

Choose a reason for hiding this comment

elliedavidson commented Aug 7, 2023 •

edited

Loading