Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ed/debug web server #1522

Merged
merged 10 commits into from
Aug 8, 2023
Merged

Ed/debug web server #1522

merged 10 commits into from
Aug 8, 2023

Conversation

elliedavidson
Copy link
Member

This PR:

  • Reduces the number of successful views needed for the web server, since it will naturally be slower than the memory network
  • Removes old tests from the web server crate

shenkeyao
shenkeyao previously approved these changes Aug 7, 2023
Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe sync with main again in case test_with_failures causes the CI to fail.

@shenkeyao
Copy link
Member

LGTM. Maybe sync with main again in case test_with_failures causes the CI to fail.

Oh there are also format errors.

@elliedavidson elliedavidson merged commit a9320e2 into main Aug 8, 2023
6 of 7 checks passed
@elliedavidson elliedavidson deleted the ed/debug_web_server branch August 8, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants