Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Republish dht keys #1532

Merged
merged 4 commits into from
Aug 14, 2023
Merged

Republish dht keys #1532

merged 4 commits into from
Aug 14, 2023

Conversation

DieracDelta
Copy link
Contributor

By default, republish DHT keys every 8 hours and set expiry for every 4 days. Enable these values as configuration options by the networking layer. Closes #1531

elliedavidson
elliedavidson previously approved these changes Aug 9, 2023
Copy link
Member

@elliedavidson elliedavidson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Member

@shenkeyao shenkeyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for a comment about the ttl setting.

libp2p-networking/src/network/node.rs Outdated Show resolved Hide resolved
@DieracDelta DieracDelta merged commit f193182 into main Aug 14, 2023
6 of 7 checks passed
@Ancient123 Ancient123 deleted the jr/republish_keys branch October 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Republish dht keys
3 participants