Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update consensus state even if missing parent info #1866

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Update consensus state even if missing parent info #1866

merged 3 commits into from
Oct 5, 2023

Conversation

shenkeyao
Copy link
Member

  • Removes commitment check from is_valid_cert.
  • Checks commitment only if parent leaf is found.
  • Updates the state even if missing parent leaf.
  • Adds a TODO to handle no vote correctly.

@Ancient123 Ancient123 merged commit b5c6026 into ed/timeout-hotfix Oct 5, 2023
5 of 6 checks passed
@Ancient123 Ancient123 deleted the keyao/update-state branch October 5, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ancient123 Ancient123 Ancient123 approved these changes

@bfish713 bfish713 Awaiting requested review from bfish713

@dailinsubjam dailinsubjam Awaiting requested review from dailinsubjam

@elliedavidson elliedavidson Awaiting requested review from elliedavidson

@rob-maron rob-maron Awaiting requested review from rob-maron

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shenkeyao @Ancient123 @bfish713