Make Membership::leader() return a Result<_>
#3738
Merged
+1,683
−743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfish713
reviewed
Oct 11, 2024
| @@ -108,35 +108,31 @@ impl<TYPES: NodeType, I: NodeImplementation<TYPES>, V: Versions> DaTaskState<TYP | |||
| // the `DaProposalRecv` event. Otherwise, the view number subtraction below will | |||
| // cause an overflow error. | |||
| // TODO ED Come back to this - we probably don't need this, but we should also never receive a DAC where this fails, investigate block ready so it doesn't make one for the genesis block | |||
There was a problem hiding this comment.
Can we resolve this TODO comment? I don't think receiving a proposal has much to do with the block ready event. A bad leader could send us proposals for old views so we need this check to discard them early.
Longer term follow up, what if we get a valid DAProposal late, is there any value in backfilling the leaf with the full block data?
|
With my PR having merged (3755) this one will need to be rebased |
ss-es
force-pushed
the
ss/fallible-leader
branch
from
d23ec22
to
f6c3d19
Compare
Closed
bfish713
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Makes the
leaderfunction fallible, returning ananyhow::Result. As a consequence of this, a lot of task logic was refactored to also return ananyhow::Result.This PR does not:
This is not a complete refactor towards returning
anyhow::Resultfrom all tasks, but it moves us most of the way towards that.Key places to review:
It's worth checking that each
ensure!is equivalent (or in some cases, more correct) than the original conditional everywhere these were replaced.