Prune dependencies #3787
Open
Prune dependencies #3787
+202
−309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ss-es
approved these changes
Oct 23, 2024
| @@ -21,6 +21,6 @@ pub trait ToFields<F: Field> { | |||
| /// convert a U256 to a field element. | |||
| pub(crate) fn u256_to_field<F: PrimeField>(v: &U256) -> F { | |||
| let mut bytes = vec![0u8; 32]; | |||
| v.to_little_endian(&mut bytes); | |||
| v.write_as_little_endian(&mut bytes); | |||
There was a problem hiding this comment.
this looks like the same thing to me, though I'm not really familiar with either crate. is the U256 the same rust type?
it might be worth having someone else (@alxiong ?) confirm this is fine/won't affect downstream repos etc
There was a problem hiding this comment.
For context: eth-types and primitive-types live in the same repo
The reason for the diff is they've recently updated the names for these methods recently which wasn't yet reflected in our eth-types version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #<ISSUE_NUMBER>
This PR:
custom_debugandderivativein favor ofderive_more(we've been using all three,derive_morecovers all use-cases)mnemonicfunction from cdn-proto to hotshot-types, as it's quite simple and depending oncdn-protoonly for this function pulled in a lot of unused dependenciesethereum-typeswhen we actually use onlyU256that it re-exports from smallerprimitive-types)This PR does not:
Key places to review: