Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport release-gambit] lower priority fee for light client update #2195

Open
wants to merge 2 commits into
base: release-gambit
Choose a base branch
from
Open

[Backport release-gambit] lower priority fee for light client update #2195

wants to merge 2 commits into from
+204 −20

Conversation

alxiong
Copy link
Contributor

@alxiong alxiong commented Oct 22, 2024

Description

Backport of #2148 to release-gambit.

@alxiong
fix: lower priority fee (#2148)
54e33bf 
* use (updated) blocknative oracle from ethers-rs

* log err if price oracle failed

(cherry picked from commit 711ab84)
@alxiong
Copy link
Contributor Author

alxiong commented Oct 22, 2024 •
edited
Loading

the contract CI error is weird, I can run just sol-test just fine locally. error[E0463]: can't find crate for num_enum` sounds strange.

dig around and couldn't figure out why, help needed @sveitser, could this be a github action env issue? (shouldn't be? because we are running these tests in nix-shell... 🤔)

@sveitser
Copy link
Collaborator

I would try erasing the github cache by bumping the cache key.

@sveitser
Copy link
Collaborator

@alxiong seems to have built diff-test successfully.

@alxiong
Copy link
Contributor Author

alxiong commented Oct 23, 2024

On current release-gambit, "Test" job succeed, but here we seems to time out on
TRY 1 SLOW [>240.000s] sequencer api::sql::generic_tests::test_namespace_query

I'm not familiar with that code. also should we fix the Slow Test and TestDemoNative failure as well?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippecamacho philippecamacho Awaiting requested review from philippecamacho philippecamacho is a code owner

@ImJeremyHe ImJeremyHe Awaiting requested review from ImJeremyHe ImJeremyHe is a code owner

@sveitser sveitser Awaiting requested review from sveitser sveitser is a code owner

@jbearer jbearer Awaiting requested review from jbearer jbearer is a code owner

@tbro tbro Awaiting requested review from tbro tbro is a code owner

@imabdulbasit imabdulbasit Awaiting requested review from imabdulbasit imabdulbasit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alxiong @sveitser