Migrate "Query features with Arcade expression" to compose #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
01smito01
force-pushed
the
oliver/arcade_query_compose
branch
from
801e4ec to
268b660
Compare
hud10837
requested changes
Dec 19, 2024
There was a problem hiding this comment.
@01smito01 looks good, but I've run into a bug with the layer not being set
...e/queryfeatureswitharcadeexpression/components/QueryFeaturesWithArcadeExpressionViewModel.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| _queryStateFlow.value = QueryState(arcadeEvaluationResult.result as Double, LoadState.LOADED) | ||
| } |
There was a problem hiding this comment.
if policeBeatsLayer is null, then the load state never gets set back to LOADED
Comment on lines
101
to
103
| policeBeatsLayer = arcGISMap.operationalLayers.firstOrNull { layer -> | ||
| layer.id == "RPD_Reorg_9254" | ||
| } |
There was a problem hiding this comment.
I think this needs to go in the coroutine scope above, because if the map is not loaded then the layer remains null
hud10837
approved these changes
Dec 20, 2024
| } | ||
|
|
||
| // update query state, map is ready for user interaction | ||
| _queryStateFlow.value = QueryState() |
There was a problem hiding this comment.
Little Nitpick: I think it's a bit clearer to explicitly set this to READY_TO_START here rather than leave it as a default value
There was a problem hiding this comment.
I swithered a bit on passing READY_TO_START explicitly, but it does make things clearer. I'll add it back in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Query features with Arcade expression, but compose
Links and Data
Old version: here
Sample design: here
Sample Epic: #4961
What To Review
README.mdmakes senseHow to Test
Run the sample on the sample viewer.