Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update counting cars notebook with correct files, attributes, and parameters #1854

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

neha-sharma-geoai
Copy link
Collaborator

  • Changed the input raster files on which detect_objects operation is being run as per required resolution.
  • Cell size argument from detect_objects parameters removed as detect_objects doesnt perform well with one cell size argument for multiple imageries.
  • Updated how output feature layer is being queried as it has been updated after implementation of panoptic segmentation. Feature layers do not support layers attribute anymore.
  • Updated displaying of maps and detected features.

Checklist

Please go through each entry in the below checklist and mark an 'X' if that condition has been met. Every entry should be marked with an 'X' to be get the Pull Request approved.

  • [x ] All imports are in the first cell?
    • [x ] First block of imports are standard libraries
    • [x ] Second block are 3rd party libraries
    • [x ] Third block are all arcgis imports? Note that in some cases, for samples, it is a good idea to keep the imports next to where they are used, particularly for uncommonly used features that we want to highlight.
  • [ x] All GIS object instantiations are one of the following?
    • gis = GIS()
    • gis = GIS('home') or gis = GIS('pro')
    • gis = GIS(profile="your_online_portal")
    • gis = GIS(profile="your_enterprise_portal")
  • If this notebook requires setup or teardown, did you add the appropriate code to ./misc/setup.py and/or ./misc/teardown.py?
  • [ x] If this notebook references any portal items that need to be staged on AGOL/Python API playground, did you coordinate with a Python API team member to stage the item the correct way with the api_data_owner user?
  • [x ] If the notebook requires working with local data (such as CSV, FGDB, SHP, Raster files), upload the files as items to the Geosaurus Online Org using api_data_owner account and change the notebook to first download and unpack the files.
  • [x ] Code simplified & split out across multiple cells, useful comments?
  • [x ] Consistent voice/tense/narrative style? Thoroughly checked for typos?
  • [x ] All images used like <img src="base64str_here"> instead of <img src="https://some.url">? All map widgets contain a static image preview? (Call mapview_inst.take_screenshot() to do so)
  • [x ] All file paths are constructed in an OS-agnostic fashion with os.path.join()? (Instead of r"\foo\bar", os.path.join(os.path.sep, "foo", "bar"), etc.)
  • Is your code formatted using Jupyter Black? You can use Jupyter Black to format your code in the notebook.
  • If this notebook showcases deep learning capabilities, please go through the following checklist:
    • Are the inputs required for Export Training Data Using Deep Learning tool published on geosaurus org (api data owner account) and added in the notebook using gis.content.get function?
    • Is training data zipped and published as Image Collection? Note: Whole folder is zipped with name same as the notebook name.
    • [x ] Are the inputs required for model inferencing published on geosaurus org (api data owner account) and added in the notebook using gis.content.get function? Note: This includes providing test raster and trained model.
    • [ x] Are the inferenced results displayed using a webmap widget?
  • [x ] IF YOU WANT THIS SAMPLE TO BE DISPLAYED ON THE DEVELOPERS.ARCGIS.COM WEBSITE, ping @jyaistMap so he can add it to the list for the next deploy.

@neha-sharma-geoai neha-sharma-geoai added bug ready for review learn Issues, questions, and enhancements related to learn module labels Jun 27, 2024
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@priyankatuteja priyankatuteja merged commit 3a91835 into master Jul 9, 2024
2 checks passed
@neha-sharma-geoai neha-sharma-geoai added approved PR approved by reviewer and removed ready for review labels Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved PR approved by reviewer bug learn Issues, questions, and enhancements related to learn module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants