fix(combobox, stepper, table): respect user hidden attribute #10983
Conversation
github-actions
bot
added
the
bug
|
@josercarcamo This is missing the utilities mentioned in item 2 from the previous review. Could you update your PR to include them? Since this supersedes the previous PR, can you close it? |
There was a problem hiding this comment.
Good progress, @josercarcamo! 😎 This needs a few more tweaks, and it'll be good to go!
| @@ -97,10 +97,8 @@ | |||
| } | |||
|
|
|||
| @mixin base-component() { | |||
| :host([hidden]) { | |||
There was a problem hiding this comment.
Since the internal hide-item attribute is only applicable to certain components, can you create a separate mixin and include in applicable children?
| * Specifies whether the user set the hidden attribute in the HTML | ||
| * | ||
| */ | ||
| @property() hideItem = false; |
There was a problem hiding this comment.
Thanks for removing user from the prop name! To align with hidden, WDYT about hiddenItem?
| @@ -262,37 +262,48 @@ describe("calcite-stepper", () => { | |||
| <calcite-stepper-item heading="Step 3" id="step-3"> | |||
| <div>Step 3 content</div> | |||
| </calcite-stepper-item> | |||
| <calcite-stepper-item heading="Step 4" id="step-4" hide-item> | |||
| @@ -1642,9 +1689,8 @@ describe("keyboard navigation", () => { | |||
| await page.keyboard.press("PageUp"); | |||
| await page.waitForChanges(); | |||
| expect(await getFocusedElementProp(page, "id")).toBe("head-1b"); | |||
| await page.keyboard.down("ControlRight"); | |||
| page.keyboard.press("ControlRight"); | |||
There was a problem hiding this comment.
This should use await and changing it to press will cause it to no longer go into the expected End + ControlRight path here (i.e., ControlRight is pressed and released before End is pressed).
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Related Issue: #8623
Summary
Made items with the hide-item attribute added by the user stay hidden.
This PR supersedes #10515