feat(list-item): deprecate open/close props in favor of expanded/collapsed #11003
+98
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
reviewed
Dec 6, 2024
| * When `true`, a close button is added to the component. | ||
| * | ||
| * @deprecated Use `collapsible` prop instead. | ||
| */ | ||
| @property({ reflect: true }) closable = false; |
There was a problem hiding this comment.
I don't think this should be collapsible. It isn't collapsed, it isn't shown at all.
There was a problem hiding this comment.
I think closed/closable needs to remain as is.
driskull
reviewed
Dec 6, 2024
| @@ -357,20 +378,32 @@ export class ListItem | |||
| To account for this semantics change, the checks for (this.hasUpdated || value != defaultValue) was added in this method | |||
| Please refactor your code to reduce the need for this check. | |||
| Docs: https://qawebgis.esri.com/arcgis-components/?path=/docs/lumina-transition-from-stencil--docs#watching-for-property-changes */ | |||
| if (changes.has("expanded")) { | |||
| this.open = this.expanded; | |||
There was a problem hiding this comment.
I don't think this is correct. expanded should set expanded, open should set open.
I think what needs to happen is that open and expanded each need a custom setter to set the other one when one is set.
|
This PR has been automatically marked as stale because it has not had recent activity. Please close your PR if it is no longer relevant. Thank you for your contributions. |
github-actions
bot
added
the
Stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6473
Summary
Deprecate
open/closeprops in favor ofexpanded/collapsed.