fix(input): correctly apply placeholder styles #11107
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
bug
jcfranco
approved these changes
Dec 18, 2024
| &:placeholder-shown { | ||
| @apply text-ellipsis; | ||
| } | ||
| } | ||
|
|
||
| // Placeholder styles | ||
| // Do not combine these style rules. The browser interprets the rule as one. Properties like -webkit can not be found in Firefox, thus the whole line is rendered as an error. |
There was a problem hiding this comment.
Nitpick: for clarity, maybe use one of the placeholder vendor prefixes instead of -webkit?
| &:placeholder-shown { | ||
| @apply text-ellipsis; | ||
| } | ||
| } | ||
|
|
||
| // Placeholder styles | ||
| // Do not combine these style rules. The browser interprets the rule as one. Properties like -webkit can not be found in Firefox, thus the whole line is rendered as an error. |
There was a problem hiding this comment.
thus the whole line is rendered as an error.
Suggestion: thus the whole selector is invalidated and is ignored.
| // Do not combine these style rules. The browser interprets the rule as one. Properties like -webkit can not be found in Firefox, thus the whole line is rendered as an error. | ||
| :-ms-input-placeholder { | ||
| @apply font-normal; | ||
| color: var(--calcite-input-placeholder-text-color, var(--calcite-color-text-3)); |
There was a problem hiding this comment.
Can we use a mixin or placeholder to DRY these styles a bit? This can be done in a follow-up.
jcfranco
added
the
no changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #8967
Summary
Breaks the placeholder styles into separate lines to avoid a browser specific selector erroring out the whole line.
BEGIN_COMMIT_OVERRIDE
END_COMMIT_OVERRIDE