Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of toLatLngBounds #1394

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

gavinr-maps
Copy link
Contributor

@gavinr-maps gavinr-maps commented Oct 24, 2024

Resolves #1386 (also possibly related to #1200 ?)

After this change, ESM CDNs can be used. I published this change to https://www.npmjs.com/package/el-esm-test to be able to test it using https://esm.sh/[email protected] ... see here for an example of using that:
https://jsbin.com/xoxopus/1/edit?html,output

Note that using esm.run (JSDelivr's ESM CDN): https://esm.run/[email protected]
... does not work. We think this is a bug with esm.run and will possibly follow up with a bug report to that project. For now our recommendation will be to use esm.sh if you want to use an ESM CDN with esri-leaflet.

Copy link
Contributor

@patrickarlt patrickarlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gavinr-maps gavinr-maps merged commit 3dca4f1 into Esri:master Oct 25, 2024
9 checks passed
@gavinr-maps gavinr-maps deleted the 1386-esm-cdn branch October 25, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when using ESM CDNs - The requested module does not provide an export named 'toLatLngBounds'
2 participants