Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add CmdlineEnter event to autocmd #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phgz
Copy link

@phgz phgz commented Jul 18, 2023

To be able to paste into cmdline with system clipboard

To be able to paste into cmdline with system clipboard
@EtiamNullam
Copy link
Owner

EtiamNullam commented Jul 21, 2023

Seems like you're subscribing to the event in schedule_disable_of_continuous_clipboard_sync_on_focus_change function but it should be done in schedule_clipboard_sync_on_focus_change function instead. Currently your solution will not sync with system clipboard, instead it will wrongly assume focus events are supported in the client on cmdline enter.

I was considering hooking to CmdlineEnter event before as well but seems like it can fire too often and impact performace. Despite that it still won't solve every case where we might miss focus change event (hit-enter-prompt or just busy).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants