Proto migrations, ide name fix #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saransh Saini seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
fortenforge
approved these changes
Sep 13, 2024
| @@ -66,7 +66,7 @@ public async Task InitializeAsync() | |||
| await PrepareAsync(); | |||
|
|
|||
| _metadata.request_id = 0; | |||
| _metadata.ide_name = "visual_studio"; | |||
| _metadata.ide_name = "vscode"; | |||
There was a problem hiding this comment.
add a TODO to change back
michaelli611
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proto was out of date in places, especially with internal changes changing some proto names. Changed those manually. Also kept the previous names for backward compatibility.
Ide name is causing issues on the ls side. Quick fix to assuage that until new release