add proto and path checks #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Saransh Saini seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
fortenforge
approved these changes
Sep 19, 2024
CodeiumVS/Commands.cs
Outdated
| @@ -308,6 +308,7 @@ protected override void BeforeQueryStatus(EventArgs e) | |||
|
|
|||
| protected override async Task ExecuteAsync(OleMenuCmdEventArgs e) | |||
| { | |||
| await CodeiumVSPackage.Instance.LogAsync("IN WINDOW DILAOG"); | |||
There was a problem hiding this comment.
might as well spell this right if you're gonna leave it in
fortenforge
approved these changes
Sep 20, 2024
| @@ -318,7 +318,6 @@ protected override async Task ExecuteAsync(OleMenuCmdEventArgs e) | |||
| // highlight the selected codeblock | |||
| TextHighlighter? highlighter = TextHighlighter.GetInstance(docView.TextView); | |||
| highlighter?.AddHighlight(start_position, end_position - start_position); | |||
|
|
|||
There was a problem hiding this comment.
Eventually we should add a formatter to prevent these whitespace changes from making it in
Comment on lines
741
to
747
| if (!string.IsNullOrEmpty(project.FullName)) | ||
| { | ||
| string projectDir = Path.GetDirectoryName(project.FullName); | ||
| await _package.LogAsync($"Project Dir: {projectDir}"); | ||
| AddTrackedWorkspaceResponse response = await AddTrackedWorkspaceAsync(projectDir); | ||
| if (response != null) | ||
| { |
There was a problem hiding this comment.
Should we log the project.FullName as well? Seeing as that's actually what's being used now?
Suggested change
| if (!string.IsNullOrEmpty(project.FullName)) | |
| { | |
| string projectDir = Path.GetDirectoryName(project.FullName); | |
| await _package.LogAsync($"Project Dir: {projectDir}"); | |
| AddTrackedWorkspaceResponse response = await AddTrackedWorkspaceAsync(projectDir); | |
| if (response != null) | |
| { | |
| await _package.LogAsync($"Project FullName: {project.FullName}"); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AddTrackedWorkspace RPC was failing because of a bad path being passed in, just need to add a check for that.
Noticed some proto were missing, added those in too.
Previous proto additions were incorrect, deleted some of them.