Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V126 edits #613

Merged
merged 3 commits into from
Aug 5, 2024
Merged

V126 edits #613

merged 3 commits into from
Aug 5, 2024

Conversation

hover2pi
Copy link
Member

@hover2pi hover2pi commented Aug 5, 2024

Updates tooltips to show better Teff and source type into and adds text to plot description for Contamination Tool.
Also bumps the version number in the footer and fixes a link typo.

@pep8speaks
Copy link

Hello @hover2pi, Thank you for submitting the Pull Request !

Line 43:46: E261 at least two spaces before inline comment
Line 46:1: E402 module level import not at top of file
Line 48:162: E231 missing whitespace after ':'
Line 49:164: E231 missing whitespace after ':'
Line 50:165: E231 missing whitespace after ':'
Line 62:21: E128 continuation line under-indented for visual indent
Line 63:21: E128 continuation line under-indented for visual indent
Line 137:36: E226 missing whitespace around arithmetic operator
Line 207:94: E231 missing whitespace after ','
Line 526:51: E261 at least two spaces before inline comment
Line 569:64: E261 at least two spaces before inline comment
Line 570:64: E261 at least two spaces before inline comment
Line 571:64: E261 at least two spaces before inline comment
Line 661:161: E241 multiple spaces after ','
Line 705:42: E128 continuation line under-indented for visual indent
Line 706:42: E128 continuation line under-indented for visual indent
Line 720:39: E127 continuation line over-indented for visual indent
Line 790:37: E261 at least two spaces before inline comment
Line 790:37: E262 inline comment should start with '# '
Line 930:16: E261 at least two spaces before inline comment
Line 940:59: E226 missing whitespace around arithmetic operator
Line 1226:9: E303 too many blank lines (2)
Line 1288:18: E261 at least two spaces before inline comment
Line 1288:18: E262 inline comment should start with '# '

If you have not done so, please consult PEP8 and PEP257

Copy link
Collaborator

@nespinoza nespinoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@nespinoza nespinoza merged commit ea5f3b9 into develop Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants