fix enable checkbox for optimistic user on workspace members page

Expensify · Nov 7, 2024 · c47ecdd · c47ecdd
1 parent afa7b33
commit c47ecdd
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 1 deletion.
diff --git a/src/components/SelectionList/TableListItem.tsx b/src/components/SelectionList/TableListItem.tsx
@@ -69,7 +69,7 @@ function TableListItem<TItem extends ListItem>({
                             accessibilityLabel={item.text ?? ''}
                             role={CONST.ROLE.BUTTON}
                             // eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
-                            disabled={isDisabled || item.isDisabledCheckbox}
+                            disabled={(isDisabled && !item.shouldPreventDisableCheckboxIfDisabled) || item.isDisabledCheckbox}
                             onPress={handleCheckboxPress}
                             style={[styles.cursorUnset, StyleUtils.getCheckboxPressableStyle(), item.isDisabledCheckbox && styles.cursorDisabled, styles.mr3, item.cursorStyle]}
                         >

diff --git a/src/components/SelectionList/types.ts b/src/components/SelectionList/types.ts
@@ -191,6 +191,9 @@ type ListItem = {
 
     /** The style to override the default appearance */
     itemStyle?: StyleProp<ViewStyle>;
+
+    /** Whether to prevent list items from being disabled */
+    shouldPreventDisableCheckboxIfDisabled?: boolean;
 };
 
 type TransactionListItemType = ListItem &

diff --git a/src/pages/workspace/WorkspaceMembersPage.tsx b/src/pages/workspace/WorkspaceMembersPage.tsx
@@ -366,6 +366,10 @@ function WorkspaceMembersPage({personalDetails, route, policy, currentUserPerson
                 isDisabled:
                     !!details.isOptimisticPersonalDetail ||
                     (isPolicyAdmin && (policyEmployee.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || !isEmptyObject(policyEmployee.errors))),
+                shouldPreventDisableCheckboxIfDisabled: !(
+                    isPolicyAdmin &&
+                    (policyEmployee.pendingAction === CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE || !isEmptyObject(policyEmployee.errors))
+                ),
                 cursorStyle: details.isOptimisticPersonalDetail ? styles.cursorDefault : {},
                 text: formatPhoneNumber(PersonalDetailsUtils.getDisplayNameOrDefault(details)),
                 alternateText: formatPhoneNumber(details?.login ?? ''),