Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-04-09] [TS migration] Migrate 'SidebarTest.js' test to TypeScript #25315

Closed
melvin-bot bot opened this issue Aug 17, 2023 · 19 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2

Comments

@melvin-bot
Copy link

melvin-bot bot commented Aug 17, 2023

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path Dependencies
tests/unit/SidebarTest.js 8
@melvin-bot
Copy link
Author

melvin-bot bot commented Sep 11, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

@melvin-bot melvin-bot bot added the Monthly KSv2 label Sep 11, 2023
Copy link
Author

melvin-bot bot commented Nov 23, 2023

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@melvin-bot melvin-bot bot closed this as completed Nov 23, 2023
@melvin-bot melvin-bot bot reopened this Nov 23, 2023
@melvin-bot melvin-bot bot closed this as completed Feb 5, 2024
Copy link
Author

melvin-bot bot commented Feb 5, 2024

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@mountiny mountiny added NewFeature Something to build that is a new item. and removed Not a priority labels Feb 8, 2024
Copy link
Author

melvin-bot bot commented Feb 8, 2024

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Monthly KSv2 labels Feb 8, 2024
@mountiny mountiny reopened this Feb 8, 2024
@abekkala abekkala added Monthly KSv2 and removed Weekly KSv2 labels Feb 15, 2024
@ruben-rebelo
Copy link
Contributor

I am Ruben Rebelo from Callstack - expert contributor group. I’d like to work on this job.

@abekkala abekkala added Daily KSv2 and removed Monthly KSv2 labels Feb 26, 2024
@abekkala
Copy link
Contributor

Thanks @ruben-rebelo

@abekkala
Copy link
Contributor

PR has not yet deployed

@melvin-bot melvin-bot bot removed the Overdue label Feb 29, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 4, 2024
Copy link
Author

melvin-bot bot commented Mar 4, 2024

@abekkala, @ruben-rebelo Whoops! This issue is 2 days overdue. Let's get this updated quick!

@abekkala
Copy link
Contributor

abekkala commented Mar 4, 2024

not overdue - not deployed yet

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 4, 2024
@abekkala
Copy link
Contributor

abekkala commented Mar 8, 2024

not overdue - not deployed

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 8, 2024
Copy link
Author

melvin-bot bot commented Mar 11, 2024

@abekkala, @ruben-rebelo Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@abekkala
Copy link
Contributor

PR has not yet deployed

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Mar 11, 2024
@abekkala
Copy link
Contributor

@ruben-rebelo can you give a status update on this one?

@melvin-bot melvin-bot bot removed the Overdue label Mar 15, 2024
@ruben-rebelo
Copy link
Contributor

Hello @abekkala, this was on internal review, I'm opening the PR for review.

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels Mar 15, 2024
@abekkala
Copy link
Contributor

@ruben-rebelo is there a delay in moving the PR along?

@abekkala
Copy link
Contributor

payment will be made via the other issue #25314 (comment)

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Apr 2, 2024
@melvin-bot melvin-bot bot changed the title [TS migration] Migrate 'SidebarTest.js' test to TypeScript [HOLD for payment 2024-04-09] [TS migration] Migrate 'SidebarTest.js' test to TypeScript Apr 2, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Apr 2, 2024
Copy link
Author

melvin-bot bot commented Apr 2, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link
Author

melvin-bot bot commented Apr 2, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.58-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-04-09. 🎊

For reference, here are some details about the assignees on this issue:

Copy link
Author

melvin-bot bot commented Apr 2, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@ruben-rebelo] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@abekkala] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production NewFeature Something to build that is a new item. Task Typescript Migration Weekly KSv2
Projects
Development

No branches or pull requests

3 participants