[No QA][TS migration] Migrate multiple test to typescript #37396

ruben-rebelo · 2024-02-28T08:22:55Z

Details

[TS migration] Migrate multiple test to TypeScript

Fixed Issues

$ #25314
$ #25315
$ #25316
$ #25317
$ #25318
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console
Run E2E test works as before
Run Unit tests works as before

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

N/a

Android: mWeb Chrome

N/a

iOS: Native

N/a

iOS: mWeb Safari

N/a

MacOS: Chrome / Safari

N/a

MacOS: Desktop

N/a

…BarTest and TestHelper

VickyStash · 2024-02-29T10:22:42Z

tests/unit/CurrencyUtilsTest.ts

+                if (isEmptyObject(currencyCodeList)) {
+                    return;
+                }


Why this check is needed?

VickyStash · 2024-02-29T10:26:51Z

tests/unit/IOUUtilsTest.ts

            const usdPendingTransaction = TransactionUtils.buildOptimisticTransaction(100, 'USD', iouReport.reportID);
            const aedPendingTransaction = TransactionUtils.buildOptimisticTransaction(100, 'AED', iouReport.reportID);
+            const MergeQueries: Record<`${typeof ONYXKEYS.COLLECTION.TRANSACTION}${string}`, NullishDeep<Transaction>> = {};


Maybe you can use CollectionDataSet type here

VickyStash · 2024-02-29T10:27:13Z

tests/unit/IOUUtilsTest.ts

-                    pendingAction: null,
-                },
-            }).then(() => {
+            const MergeQueries: Record<`${typeof ONYXKEYS.COLLECTION.TRANSACTION}${string}`, NullishDeep<Transaction>> = {};


VickyStash · 2024-02-29T10:28:21Z

tests/unit/SidebarTest.ts

@@ -50,13 +38,15 @@ describe('Sidebar', () => {
    describe('archived chats', () => {
        it('renders the archive reason as the preview message of the chat', () => {
            const report = {
+                // @ts-expect-error TODO: Remove this once LHNTestUtils (https://github.com/Expensify/App/issues/25320) is migrated to TypeScript.


It's merged, so please merge the latest main

tests/unit/SidebarTest.ts

VickyStash · 2024-02-29T10:44:35Z

tests/utils/TestHelper.ts

+import type {PersonalDetails, Report} from '@src/types/onyx';
+import waitForBatchedUpdates from './waitForBatchedUpdates';
+
+type MockFetch = ReturnType<typeof jest.fn> & {pause?: () => void; fail?: () => void; succeed?: () => void; resume?: () => Promise<void>};


Also maybe we can use just jest.Mock & instead of ReturnType<typeof jest.fn> &

Suggested change

type MockFetch = ReturnType<typeof jest.fn> & {pause?: () => void; fail?: () => void; succeed?: () => void; resume?: () => Promise<void>};

type MockFetch = ReturnType<typeof jest.fn> & {

pause?: () => void;

fail?: () => void;

succeed?: () => void;

resume?: () => Promise<void>

};

fabioh8010 · 2024-03-01T07:16:51Z

tests/e2e/compare/compare.ts

    // Unique test scenario names
-    const names = [...new Set([..._.keys(compareEntries), ..._.keys(baselineEntries || {})])];
+    const compareKeys = Object.keys(compareEntries);
+    const baselineKeys = baselineEntries ? Object.keys(baselineEntries) : [];


Suggested change

const baselineKeys = baselineEntries ? Object.keys(baselineEntries) : [];

const baselineKeys = Object.keys(baselineEntries ?? {});

wdyt?

tests/e2e/compare/compare.ts

# Conflicts: # tests/utils/TestHelper.js

# Conflicts: # tests/e2e/measure/math.ts

fabioh8010 · 2024-03-08T10:06:13Z

tests/unit/SidebarTest.ts

-                    .then(() =>
-                        Onyx.multiSet({
+                    .then(() => {
+                        const reportCollection = {


Suggested change

const reportCollection = {

const reportCollection: ReportActionCollectionDataSet = {

this works?

fabioh8010 · 2024-03-08T10:06:19Z

tests/unit/SidebarTest.ts

+                            [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
+                        } as ReportCollectionDataSet;
+
+                        const reportAction = {


fabioh8010 · 2024-03-08T10:06:26Z

tests/unit/SidebarTest.ts

-                    .then(() =>
-                        Onyx.multiSet({
+                    .then(() => {
+                        const reportCollection = {


fabioh8010 · 2024-03-08T10:06:30Z

tests/unit/SidebarTest.ts

+                            [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
+                        } as ReportCollectionDataSet;
+
+                        const reportAction = {


fabioh8010 · 2024-03-08T10:07:02Z

tests/utils/TestHelper.ts

+            // Response is the same for calls to Authenticate and BeginSignIn
+            HttpUtils.xhr = jest.fn().mockImplementation(() => {
+                // Your mocked response object
+                const mockedResponse = {


What about this comment?

fabioh8010 · 2024-03-08T10:07:07Z

tests/utils/TestHelper.ts

+    const originalXhr = HttpUtils.xhr;
+    HttpUtils.xhr = jest.fn().mockImplementation(() => {
+        // Your mocked response object
+        const mockedResponse = {


What about this comment?

fabioh8010 · 2024-03-08T10:07:55Z

tests/utils/TestHelper.ts

+
+    HttpUtils.xhr = jest.fn().mockImplementation(() => {
+        // Your mocked response object
+        const mockedResponse = {


Suggested change

const mockedResponse = {

const mockedResponse: Response = {

Could we type this object?

fabioh8010 · 2024-03-08T15:41:29Z

tests/utils/TestHelper.ts

@@ -18,7 +19,13 @@ type MockFetch = ReturnType<typeof jest.fn> & {
    resume?: () => Promise<void>;
 };

-type Response = {ok: boolean; json: () => Promise<{jsonCode: number}>};
+type Response = {


Could we use Response from src/types/onyx/Response.ts?

The response type differs from the OnyxType, should we update the OnyxType.Reponse to comply with the type of the TestHelper?

Here is my suggestion

diff --git a/tests/utils/TestHelper.ts b/tests/utils/TestHelper.ts index 097433e881..10313ad46d 100644 --- a/tests/utils/TestHelper.ts +++ b/tests/utils/TestHelper.ts @@ -1,12 +1,11 @@ import Str from 'expensify-common/lib/str'; -import type {OnyxUpdate} from 'react-native-onyx'; import Onyx from 'react-native-onyx'; import CONST from '@src/CONST'; import * as Session from '@src/libs/actions/Session'; import HttpUtils from '@src/libs/HttpUtils'; import * as NumberUtils from '@src/libs/NumberUtils'; import ONYXKEYS from '@src/ONYXKEYS'; -import type {PersonalDetails, Report} from '@src/types/onyx'; +import type {Response as OnyxResponse, PersonalDetails, Report} from '@src/types/onyx'; import waitForBatchedUpdates from './waitForBatchedUpdates'; type MockFetch = ReturnType<typeof jest.fn> & { @@ -19,14 +18,7 @@ type MockFetch = ReturnType<typeof jest.fn> & { resume?: () => Promise<void>; }; -type Response = { - ok?: boolean; - json?: () => Promise<{jsonCode: number}>; - jsonCode?: number; - onyxData?: OnyxUpdate[]; -}; - -type QueueItem = (value: Response | PromiseLike<Response>) => void; +type QueueItem = (value: Partial<Response> | PromiseLike<Partial<Response>>) => void; type FormData = { entries: () => Array<[string, string | Blob]>; @@ -58,7 +50,7 @@ function signInWithTestUser(accountID = 1, login = '[email protected]', password = ' HttpUtils.xhr = jest.fn().mockImplementation(() => { // Your mocked response object - const mockedResponse: Response = { + const mockedResponse: OnyxResponse = { onyxData: [ { onyxMethod: Onyx.METHOD.MERGE, @@ -176,7 +168,7 @@ function getGlobalFetchMock() { let isPaused = false; let shouldFail = false; - const getResponse = () => + const getResponse = (): Partial<Response> => shouldFail ? { ok: true, @@ -256,4 +248,4 @@ const createAddListenerMock = () => { return {triggerTransitionEnd, addListener}; }; -export {getGlobalFetchMock, signInWithTestUser, signOutTestUser, setPersonalDetails, buildPersonalDetails, buildTestReportComment, assertFormDataMatchesObject, createAddListenerMock}; +export {assertFormDataMatchesObject, buildPersonalDetails, buildTestReportComment, createAddListenerMock, getGlobalFetchMock, setPersonalDetails, signInWithTestUser, signOutTestUser};

Thank you! Got it 👍
Updated

VickyStash · 2024-03-12T09:53:44Z

tests/utils/TestHelper.ts

+    pause?: () => void;
+
+    fail?: () => void;
+
+    succeed?: () => void;
+
+    resume?: () => Promise<void>;


Suggested change

pause?: () => void;

fail?: () => void;

succeed?: () => void;

resume?: () => Promise<void>;

pause?: () => void;

fail?: () => void;

succeed?: () => void;

resume?: () => Promise<void>;

VickyStash · 2024-03-12T09:54:57Z

tests/utils/TestHelper.ts

+    const originalXhr = HttpUtils.xhr;
+    HttpUtils.xhr = jest.fn().mockImplementation(() => {
+        // Your mocked response object
+        const mockedResponse = {


What about this comment?

VickyStash · 2024-03-12T09:55:02Z

tests/utils/TestHelper.ts

+            // Response is the same for calls to Authenticate and BeginSignIn
+            HttpUtils.xhr = jest.fn().mockImplementation(() => {
+                // Your mocked response object
+                const mockedResponse = {


What about this comment?

VickyStash · 2024-03-12T09:59:49Z

tests/unit/SidebarTest.ts

+                        const reportCollection: ReportActionCollectionDataSet = {
+                            [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
+                        } as ReportCollectionDataSet;


Suggested change

const reportCollection: ReportActionCollectionDataSet = {

[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,

} as ReportCollectionDataSet;

const reportCollection: ReportCollectionDataSet = {

[`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,

};

VickyStash · 2024-03-12T10:14:32Z

tests/unit/SidebarTest.ts

+                    .then(() => {
+                        const reportCollection: ReportCollectionDataSet = {
+                            [`${ONYXKEYS.COLLECTION.REPORT}${report.reportID}`]: report,
+                        } as ReportCollectionDataSet;


Suggested change

} as ReportCollectionDataSet;

};

# Conflicts: # tests/unit/SidebarTest.ts

melvin-bot · 2024-03-15T17:34:17Z

@akinwale Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

akinwale · 2024-03-15T18:07:02Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

akinwale · 2024-03-15T18:07:41Z

@ruben-rebelo TypeScript checks and e2e test build failing.

# Conflicts: # tests/utils/TestHelper.js

ruben-rebelo · 2024-03-21T12:48:20Z

@akinwale I've updated the PR.
Reassure perfomance tests are failing but it's not related to this PR

roryabraham · 2024-03-23T08:32:07Z

looks like jest is failing now

fabioh8010 · 2024-03-26T07:03:20Z

@ruben-rebelo merge conflicts again 😕 and tests are failing

# Conflicts: # src/types/onyx/ReportAction.ts

fabioh8010 · 2024-03-26T15:51:42Z

@akinwale @roryabraham all yours!

mountiny

One comment, thank you very much!

mountiny · 2024-03-26T23:14:27Z

tests/unit/MiddlewareTest.ts

@@ -39,7 +39,7 @@ describe('Middleware', () => {
                },
                {
                    command: 'AddComment',
-                    data: {authToken: 'testToken', reportID: '1234', reportActionID: '5678', reportComment: 'foo'},
+                    data: {authToken: 'testToken', reportID: '1234', reportActionID: '5678'},


Why are we removing the reportComment here? is that not needed at all in the test?

It's not needed for the test.
This was wrong because Report doesn't have any reportComment, with the addition of the TS on this file the type started to complain.
This was working before as we are directly testing the Middleware and we expected exactly that data.
So in my opinion this can be safely removed from the test.

Ok thank you!

melvin-bot · 2024-03-27T14:21:30Z

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

mountiny · 2024-03-27T14:39:45Z

The tests were passing

OSBotify · 2024-03-29T02:26:38Z

🚀 Deployed to staging by https://github.com/mountiny in version: 1.4.58-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-04-02T11:02:54Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.58-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss · 2024-05-16T11:14:59Z

Hey @ruben-rebelo or anyone familiar with these changes. It's not a problem, but a PR was merged that didn't recently merge main, and we now need to align the changes to prevent a failing check on main. Would you mind reviewing this PR to ensure your code, and the unaligned code is being resolved correctly? Thanks

ruben-rebelo added 3 commits February 28, 2024 08:20

[TS migration] Migrate compare, currencyUtilsTest, IOUUtilsTest, Side…

1a63d65

…BarTest and TestHelper

[TS migration] Fixed compare

703bd25

[TS migratio] Lint

6b655b5

VickyStash reviewed Feb 29, 2024

View reviewed changes

fabioh8010 reviewed Mar 1, 2024

View reviewed changes

ruben-rebelo added 6 commits March 1, 2024 08:39

Merge branch 'main' into ts-migration/group3-tests

fc7dcb7

# Conflicts: # tests/utils/TestHelper.js

[TS migration][G3] Feedback

af3fd55

[TS migration][G3] Lint fix

8022a87

[TS migration][G3] Fixed lint issue

1825d3a

Merge branch 'main' into ts-migration/group3-tests

3f02374

# Conflicts: # tests/e2e/measure/math.ts

[TS migration][G3] TS fix

de50342

fabioh8010 reviewed Mar 8, 2024

View reviewed changes

[TS migration][G3] Feedback

e6cdbd9

fabioh8010 reviewed Mar 8, 2024

View reviewed changes

[TS migration][G3] Feedback

000491f

fabioh8010 approved these changes Mar 12, 2024

View reviewed changes

VickyStash reviewed Mar 12, 2024

View reviewed changes

ruben-rebelo added 3 commits March 12, 2024 10:18

Merge branch 'main' into ts-migration/group3-tests

cca9a8d

# Conflicts: # tests/unit/SidebarTest.ts

[TS migration][G3] Feedback

fd7802b

[TS migration][G3] Updated response type

873493f

blazejkustra approved these changes Mar 12, 2024

View reviewed changes

ruben-rebelo added 2 commits March 15, 2024 17:33

Merge branch 'main' into ts-migration/group3-tests

a4468ed

[TS migration][G3] Lint

e8d3ec6

ruben-rebelo marked this pull request as ready for review March 15, 2024 17:34

ruben-rebelo requested a review from a team as a code owner March 15, 2024 17:34

melvin-bot bot requested review from akinwale and removed request for a team March 15, 2024 17:34

abekkala mentioned this pull request Mar 20, 2024

[HOLD for payment 2024-04-09] [TS migration] Migrate 'compare.js' test to TypeScript #25314

Closed

mountiny self-requested a review March 20, 2024 18:52

mountiny assigned ruben-rebelo Mar 20, 2024

ruben-rebelo added 2 commits March 21, 2024 08:33

Merge branch 'main' into ts-migration/group3-tests

a034537

# Conflicts: # tests/utils/TestHelper.js

[TS migration][G3] TS issue fixes

c884890

Merge branch 'main' into ts-migration/group3-tests

a0ded82

Merge branch 'main' into ts-migration/group3-tests

9dfd4cf

ruben-rebelo added 3 commits March 26, 2024 08:24

Merge branch 'main' into ts-migration/group3-tests

ecbdff6

# Conflicts: # src/types/onyx/ReportAction.ts

[TS migration][G3] TS fixes

3dc33fc

[TS migration][G3] Fixed unit test

3b081fd

mountiny approved these changes Mar 26, 2024

View reviewed changes

mountiny merged commit e10d4f7 into Expensify:main Mar 27, 2024
19 checks passed

melvin-bot bot added the Emergency label Mar 27, 2024

mountiny removed the Emergency label Mar 27, 2024

github-actions bot mentioned this pull request Mar 29, 2024

Deploy Checklist: New Expensify 2024-03-29 #39222

Closed

	const baselineKeys = baselineEntries ? Object.keys(baselineEntries) : [];
	const baselineKeys = Object.keys(baselineEntries ?? {});

	const reportCollection = {
	const reportCollection: ReportActionCollectionDataSet = {

[No QA][TS migration] Migrate multiple test to typescript #37396

[No QA][TS migration] Migrate multiple test to typescript #37396

Conversation

ruben-rebelo commented Feb 28, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 15, 2024

akinwale commented Mar 15, 2024

Reviewer Checklist

Screenshots/Videos

akinwale commented Mar 15, 2024

ruben-rebelo commented Mar 21, 2024

roryabraham commented Mar 23, 2024

fabioh8010 commented Mar 26, 2024

fabioh8010 commented Mar 26, 2024

mountiny left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

melvin-bot bot commented Mar 27, 2024

mountiny commented Mar 27, 2024

OSBotify commented Mar 29, 2024

OSBotify commented Apr 2, 2024

Julesssss commented May 16, 2024

ruben-rebelo commented Feb 28, 2024 •

edited

Loading