Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2024-06-20][Payment card / Subscription] Implement “Add payment card” screen (UI) #38634

Closed
MitchExpensify opened this issue Mar 19, 2024 · 14 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.

Comments

@MitchExpensify
Copy link
Contributor

MitchExpensify commented Mar 19, 2024

This covers this section of the doc https://docs.google.com/document/d/1jXV_vIsOGZuL0dMiuXDWRETAFRX64ODVAhWPtiuFXT8/edit?pli=1#bookmark=id.xawijngubbyv cc @fabioh8010

Issue OwnerCurrent Issue Owner: @lschurr
@fabioh8010
Copy link
Contributor

Hi, I'm Fábio from Callstack - expert agency - and I would like to work on this issue.

@narefyev91
Copy link
Contributor

Hey! I'm Nicolay from Callstack - will work on this flow - please assign it for me. Thanks!

@melvin-bot melvin-bot bot added the Overdue label May 27, 2024
@narefyev91 narefyev91 mentioned this issue May 29, 2024
50 tasks
@melvin-bot melvin-bot bot removed the Overdue label May 30, 2024
@trjExpensify trjExpensify added Daily KSv2 NewFeature Something to build that is a new item. and removed Monthly KSv2 labels May 30, 2024
Copy link

melvin-bot bot commented May 30, 2024

Triggered auto assignment to @lschurr (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels May 30, 2024
@trjExpensify trjExpensify added Daily KSv2 and removed Weekly KSv2 labels May 30, 2024
@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Daily KSv2 labels May 31, 2024
Copy link

melvin-bot bot commented Jun 4, 2024

Triggered auto assignment to @AndrewGable, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@amyevans amyevans assigned amyevans and rushatgabhane and unassigned AndrewGable Jun 5, 2024
@amyevans
Copy link
Contributor

amyevans commented Jun 7, 2024

Assigning @rushatgabhane as C+ since he reviewed the PR

@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Jun 11, 2024
@melvin-bot melvin-bot bot changed the title [Payment card / Subscription] Implement “Add payment card” screen (UI) [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Add payment card” screen (UI) Jun 11, 2024
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Jun 11, 2024
Copy link

melvin-bot bot commented Jun 11, 2024

Reviewing label has been removed, please complete the "BugZero Checklist".

Copy link

melvin-bot bot commented Jun 11, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.81-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-18. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 11, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

  • [@rushatgabhane] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
  • [@lschurr] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Jun 13, 2024
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Add payment card” screen (UI) [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Add payment card” screen (UI) Jun 13, 2024
Copy link

melvin-bot bot commented Jun 13, 2024

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.82-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2024-06-20. 🎊

For reference, here are some details about the assignees on this issue:

Copy link

melvin-bot bot commented Jun 13, 2024

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

@lschurr lschurr changed the title [HOLD for payment 2024-06-20] [HOLD for payment 2024-06-18] [Payment card / Subscription] Implement “Add payment card” screen (UI) [HOLD for payment 2024-06-20][Payment card / Subscription] Implement “Add payment card” screen (UI) Jun 14, 2024
@rushatgabhane
Copy link
Member

rushatgabhane commented Jun 16, 2024

            1. Go to staging.new.expensify.com/settings/subscription/add-payment-card
            2. Verify that user can see add debit card
            3. Click Add payment card
            4. Verify that user will see errors with required fields
            5. Fill all required fields
            6. Verify that no errors are shown

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Jun 18, 2024
@lschurr
Copy link
Contributor

lschurr commented Jun 19, 2024

Payment summary:

  • Contributor+: $250 @rushatgabhane (please request payment in NewDot)

@lschurr
Copy link
Contributor

lschurr commented Jun 20, 2024

Closing :)

@lschurr lschurr closed this as completed Jun 20, 2024
@JmillsExpensify
Copy link

$250 approved for @rushatgabhane

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 NewFeature Something to build that is a new item.
Projects
No open projects
Archived in project
Development

No branches or pull requests

9 participants