[$250] [HOLD for payment 2024-06-20] Hold expense - Unable to hold expense with failed scanning when there is only one expense

[m-natarajan]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 1.4.80-3
Reproducible in staging?: y
Reproducible in production?: no new feature
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Expensify/Expensify Issue URL:
Issue reported by: Applause internal team
Slack conversation:

Action Performed:

1. Go to staging.new.expensify.com
2. Go to workspace chat that has no unsettled expense.
3. Submit a scan expense with an invalid receipt.
4. Wait for the scanning to fail.
5. When the scanning fails, go to transaction thread.
6. Click 3-dot menu > Hold.
7. Enter reason and save it.
8. Return to main chat.
9. Go to transaction thread.
10. Click 3-dot menu.

Expected Result:

The held expense with failed scanning will remain held status.

Actual Result:

The held expense with failed scanning return to unheld status.

Workaround:

unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6504168_1717693758278.20240607_010526.mp4

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @alexpensify

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~019c2dfe28442e0872
• Upwork Job ID: 1803913741255552220
• Last Price Increase: 2024-06-20
• Automatic offers:
• c3024 | Contributor | 102817385

[melvin-bot]

Triggered auto assignment to @srikarparsi (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[m-natarajan]

@alexpensify FYI I haven't added the External label as I wasn't 100% sure about this issue. Please take a look and add the label if you agree it's a bug and can be handled by external contributors

[m-natarajan]

We think that this bug might be related to #wave-collect - Release 1

[srikarparsi]

I think this is probably related to this PR

[srikarparsi]

Not reproducible when reverting the PR. The PR adds functionality to hold on single expense views.

[srikarparsi]

Checking to see if we can demote this to a daily, similar to what we did here.

[tienifr]

Sorry I'm taking a look now.

[trjExpensify]

@srikarparsi @blimpich if we reverted the offending PR, do we need to check this off the deploy blocker list: #43168?

[blimpich]

@trjExpensify Yup! Didn't get around to it because I was offline when the revert was merged, but just checked it off.

[trjExpensify]

Understandable man!

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@srikarparsi] The PR that introduced the bug has been identified. Link to the PR:
• [@srikarparsi] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@srikarparsi] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@srikarparsi] Determine if we should create a regression test for this bug.
• [@srikarparsi] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@alexpensify] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[c3024]

@srikarparsi

I reviewed the related PR #43237 . Can you please reopen this and assign this issue to me for payment? Thanks!

[blimpich]

@alexpensify @srikarparsi re-opened to handle payment for @c3024

[alexpensify]

Noted, I'll work on the payment process before the due date.

[tienifr]

This issue is not caused by my PR #42374 because it even happened in transaction thread report. It has the same root cause with #41655 (comment) which is a BE issue and being worked on.

[melvin-bot]

Skipping the payment summary for this issue since all the assignees are employees or vendors. If this is incorrect, please manually add the payment summary SO.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~019c2dfe28442e0872

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @ikevin127 (External)

[melvin-bot]

📣 @c3024 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[alexpensify]

@c3024 - I've sent over an offer via Upwork. Please accept, and then I can complete the payment process. Thanks!

[c3024]

Accepted, thanks @alexpensify

[alexpensify]

Payouts due: 2024-06-20

• Contributor: Internal
• Contributor+: $250 @c3024

Upwork job is here.

[alexpensify]

All set, I've completed the payment process in Upwork. Closing!