[$250] [Search v2.1] [App] Create Keyword filter

[luacmartins]

Implement this section of the design doc for the Keyword filter only!

cc @adamgrzybowski @Kicu @WojtekBoman

Issue Owner

Current Issue Owner: @suneox

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01ff6d0b9a0f6c02fb
• Upwork Job ID: 1819041159147930925
• Last Price Increase: 2024-08-01
• Automatic offers:
• ikevin127 | Contributor | 103358660

[melvin-bot]

Triggered auto assignment to @jliexpensify (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details. Please add this Feature request to a GH project, as outlined in the SO.

[jliexpensify]

Hi @luacmartins, did you want me to assign the tagged people?

[luacmartins]

I think they need to comment on the issue before we can assign it to them

[jliexpensify]

Oh yeah, of course ha!

[luacmartins]

Trying to get this assigned

[SzymczakJ]

Hey! I’m Jakub Szymczak from Software Mansion, an expert agency, and I’d like to work on this issue!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01ff6d0b9a0f6c02fb

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @suneox (External)

[melvin-bot]

📣 @ikevin127 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[jliexpensify]

Done, thanks @289Adam289!

[289Adam289]

@luacmartins What should keyword filter page look like? I assumed it should be similar to merchant filter but "Has keywords" description in docs implies that page should allow for multiple keywords to be entered.

[luacmartins]

It should be a text input. Users can enter any value in it

[ikevin127]

⚠️ Production deploy automation failed here -> this should be on [HOLD for Payment 2024-08-20] according to yesterday’s production deploy confirmed in #46799 (comment) and deploy checklist.

[jliexpensify]

Payment Summary

• C: @289Adam289 (Agency)
• C+: @ikevin127 $250

Upwork job

[ikevin127]

@jliexpensify Thank you!
Do you mind adding the Bug label as well for auto-assigned BZ team member to handle payment once due ?

[jliexpensify]

@ikevin127 - I am BZ!

[ikevin127]

My bad, was looking for that Bug label without checking 🤦‍♂️

[jliexpensify]

All good, usually that label is applied but since its a NewFeature, BZ gets assigned.

[ikevin127]

cc @jliexpensify

[jliexpensify]

Thanks for the bump, but It's still the 19th in the US, right? 😅 that's the timezone that we go off for payments

[jliexpensify]

@ikevin127 any checklist needed here?

EDIT: paid and job closed

[ikevin127]

Thanks for the payment 💯
Regarding checklist / regression tests, I was told by @luacmartins in a few of the search v2.1 issues (ref) that, quote:

No, we'll add it as part of the project wrap up

[luacmartins]

Correct ^

[jliexpensify]

Awesome, all good. Closing!