[HOLD for payment 2024-09-16] [$125] Advanced approvals - Left and right side of the empty state image is cut off

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.29-0
Reproducible in staging?: Y
Reproducible in production?: N
Email or phone of affected tester (no customers): [email protected]
Issue reported by: Applause Internal Team

Action Performed:

1. Launch New Expensify app.
2. Go to workspace settings > Workflows.
3. Enable Add approvals.
4. Click on the existing approval workflow.
5. Click Additional approver.

Expected Result:

The empty state image will not be cut off.

Actual Result:

The left and right side of the empty state image is cut off.

Workaround:

Unknown

Platforms:

• Android: Native
• Android: mWeb Chrome
• iOS: Native
• iOS: mWeb Safari
• MacOS: Chrome / Safari
• MacOS: Desktop

Screenshots/Videos

Bug6592373_1725411670725.cut.mp4

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01b31f1fa567915230
• Upwork Job ID: 1831311067019688732
• Last Price Increase: 2024-09-04
• Automatic offers:
• DylanDylann | Contributor | 103814857

Issue Owner

Current Issue Owner: @slafortune

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot]

Triggered auto assignment to @mountiny (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[github-actions]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

We think that this bug might be related to #wave-control

[bernhardoj]

Edited by proposal-police: This proposal was edited at 2024-09-04 09:56:00 UTC.

Proposal

Please re-state the problem that we are trying to solve in this issue.

The approver empty state icon is cut off.

What is the root cause of that problem?

The icon height is bigger (144) than the width that we set to the view (136).

App/src/pages/workspace/workflows/approvals/WorkspaceWorkflowsApprovalsApproverPage.tsx

Lines 235 to 243 in 562d7b4

	<BlockingView
	icon={Illustrations.TurtleInShell}
	iconWidth={variables.emptyListIconWidth}
	iconHeight={variables.emptyListIconHeight}
	title={translate('workflowsPage.emptyContent.title')}
	subtitle={translate('workflowsPage.emptyContent.approverSubtitle')}
	subtitleStyle={styles.textSupporting}
	containerStyle={styles.pb10}
	/>

Also, we don't set the content fit prop and the content fit is cover by default, so the image/icon is cut off.

App/src/components/Icon/index.tsx

Line 70 in 562d7b4

contentFit = 'cover',

What changes do you think we should make in order to solve the problem?

First, set the content fit to contain.

contentFitImage='contain'

Then, we can keep the current size, 136, or increase it to 144.

Or change the default content fit to contain.

App/src/components/Icon/index.tsx

Line 70 in 562d7b4

contentFit = 'cover',

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01b31f1fa567915230

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @fedirjh (External)

[melvin-bot]

Upwork job price has been updated to $125

[mountiny]

This is a minor ui thing. @bernhardoj can you identify which PR caused this?

[bernhardoj]

The approver empty view was recently added in #47848

[melvin-bot]

📣 @DylanDylann 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[mountiny]

Adding @DylanDylann as a C+ from the offending PR

[bernhardoj]

PR is ready

[DylanDylann]

@slafortune let's pay @bernhardoj only and close this one. The checklist is no need here.

[mountiny]

$125 to @bernhardoj

[bernhardoj]

Requested in ND.

[JmillsExpensify]

$125 approved for @bernhardoj

[DylanDylann]

@slafortune @mountiny Let's close this issue