Video player #30829

Skalakid · 2023-11-03T09:50:14Z

Details

Fixed Issues

$ #20471
$ #32770
PROPOSAL: #20471

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  - Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

android.native.webm

Android: mWeb Chrome

android.web.webm

iOS: Native

ios.native.mp4

iOS: mWeb Safari

ios.web.mp4

MacOS: Chrome / Safari

web_H.265.mp4

MacOS: Desktop

desktop.mov

OSBotify · 2024-02-26T20:52:32Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.43-20 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

jjcoffee · 2024-03-05T11:19:13Z

Coming from #36865, we missed adding the ability to replay the video once it ends when the video is full screen. More details here.

situchan · 2024-03-06T16:33:47Z

src/components/Attachments/AttachmentView/index.js

    const theme = useTheme();
    const styles = useThemeStyles();
    const StyleUtils = useStyleUtils();
    const [loadComplete, setLoadComplete] = useState(false);
+    const isVideo = Str.isVideo(source);


This line caused crash - #36834
source is not always string, i.e. svg

parasharrajat · 2024-03-13T17:16:00Z

src/components/VideoPlayer/utils.ts

+
+// Converts milliseconds to 'minutes:seconds' format
+const convertMillisecondsToTime = (milliseconds: number) => {
+    const date = new Date(milliseconds);


Using the local Date object caused the time format issues. #37216 (comment)

alitoshmatov · 2024-03-17T11:21:54Z

src/components/VideoPlayerContexts/PlaybackContext.js

+    const updateCurrentlyPlayingURL = useCallback(
+        (url) => {
+            if (currentlyPlayingURL && url !== currentlyPlayingURL) {
+                pauseVideo();


Not directly caused this issue but related pauseVideo is being called even if the video context is already destroyed. This is causing error in console. ref: #37142 (comment)

eVoloshchak · 2024-03-19T00:14:11Z

src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

+                icon: Expensicons.Download,
+                text: translate('common.download'),
+                onSelected: () => {
+                    downloadAttachment();


Coming from #36833, we shouldn't show the Download button for the local file preview

src/components/VideoPopoverMenu/index.js

ishpaul777 · 2024-04-07T22:36:59Z

This PR caused this bug - Play&Pause buttons don't function in preview mode if expanded the video before

RCA explained here - #36873 (comment)

rayane-djouah · 2024-05-03T18:20:01Z

src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

+    const downloadAttachment = useCallback(() => {
+        currentVideoPlayerRef.current.getStatusAsync().then((status) => {
+            const sourceURI = `/${Url.getPathFromURL(status.uri)}`;
+            fileDownload(sourceURI);
+        });
+    }, [currentVideoPlayerRef]);


This PR caused this bug:

[HOLD for payment 2024-05-09] [$250] Incorrect video downloaded #40647

RCA explained here - #40647 (comment)

rushatgabhane · 2024-05-13T09:46:04Z

src/components/VideoPlayer/BaseVideoPlayer.js

+    const canUseTouchScreen = DeviceCapabilities.canUseTouchScreen();
+    const isCurrentlyURLSet = currentlyPlayingURL === url;
+
+    const togglePlayCurrentVideo = useCallback(() => {


Hey, there was a console error - #39253

More details here.

s77rt · 2024-06-03T19:02:11Z

src/components/Attachments/AttachmentCarousel/index.js

+        if (_.isEqual(attachments, attachmentsFromReport)) {
+            return;
+        }


This early return caused the state variable page to be stale (at 0) where it should have been updated to -1 if the attachments array is empty

hungvu193 · 2024-06-04T02:14:55Z

src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

+    const updatePlaybackSpeed = useCallback(
+        (speed) => {
+            setCurrentPlaybackSpeed(speed);
+            currentVideoPlayerRef.current.setStatusAsync({rate: speed});


This line caused this bug:
#40646

Here's the RCA:
#40646 (comment)

allroundexperts · 2024-08-11T22:35:11Z

src/components/VideoPlayerContexts/VideoPopoverMenuContext.js

+                        text: speed.toString(),
+                        onSelected: () => {
+                            updatePlaybackSpeed(speed);
+                        },


We should have taken care of the highlighting of the sub item once selected. This caused #42425

ikevin127 · 2024-09-05T00:23:25Z

src/CONST.ts

+
+    VIDEO_PLAYER: {
+        POPOVER_Y_OFFSET: -30,
+        PLAYBACK_SPEEDS: [0.25, 0.5, 1, 1.5, 2],


Turns out that PLAYBACK_SPEEDS required some additional granularity which led to this issue:

[HOLD for Payment 2024-09-06][$250] mWeb - Video - In welcome video, all playback speed options is not shown in normal mode #47205

We fixed the issue by adding a wider range of PLAYBACK_SPEEDS, more details in the ^ issue / proposal.

mczernek and others added 30 commits September 29, 2023 16:21

Add expo-modules to application.

87b7f76

Update package-lock.json after adding expo-modules.

c279f81

Bump kotlin to 1.8.20 to make it compatible with expo-modules.

63405fa

Prettier on metro.config.js

2d00d23

Add patch for plaid-sdk

a951a31

Merge branch 'main' into expo-modules

80a1702

Add Video Player

11ac0d0

clear code

6c49f76

fix send attachment modal

389bdd7

Merge branch 'main' into video-player

7ac9cb4

add icons

de64ca5

add volume slider

b330c89

upgrade volume action button

784d62e

add basic popover menu

74e16b6

prepare frontend for backend changes

02c5c49

Merge branch 'main' into video-player

e8bb2be

Merge branch 'main' into video-player

c98202d

fix popover position

a84d96a

Merge branch 'main' into video-player

8a1af63

add basic changes for shared element logic

a059c2d

fix bugs after logic change

5069db6

add structure changes

1612192

reduced rerenders while changing volume

eb08069

fix volume slider

a38e349

fix progress bar

23bb760

fix popover displaying

33dc719

Merge branch 'main' into video-player

cefdc24

improved popover menu

699366d

move popover logic to context

798f6b8

clear structure

e857108

stitesExpensify mentioned this pull request Feb 20, 2024

[Hold for payment][$500] Chat - Video leads to not here page after reopening chat #36899

Closed

6 tasks

roryabraham mentioned this pull request Feb 20, 2024

[HOLD for payment 2024-03-07] [$500] Video - Unable to adjust volume by clicking on any part of the volume slider #36952

Closed

6 tasks

tienifr mentioned this pull request Feb 21, 2024

Fix: Attachment - Navigation arrows not disabled and PDF cannot be scrolled while zoomed in #36921

Closed

50 tasks

s77rt mentioned this pull request Feb 23, 2024

Video - Invalid file is downloaded when downloading video #37092

Closed

6 tasks

ikevin127 mentioned this pull request Feb 23, 2024

[PAID] [$500] Chat - When opening the mp4 video that was just sent, console error appears #37142

Closed

6 tasks

situchan mentioned this pull request Feb 26, 2024

fix: broken search screen on Android #37155

Merged

49 tasks

mallenexpensify mentioned this pull request Mar 5, 2024

[Pay now][$500] Payment for https://github.com/Expensify/App/pull/30829 #37798

Closed

situchan reviewed Mar 6, 2024

View reviewed changes

parasharrajat reviewed Mar 13, 2024

View reviewed changes

parasharrajat mentioned this pull request Mar 13, 2024

[HOLD for payment 2024-03-19] [$500] Video duration is displayed incorrectly #37216

Closed

6 tasks

alitoshmatov reviewed Mar 17, 2024

View reviewed changes

eVoloshchak reviewed Mar 19, 2024

View reviewed changes

parasharrajat reviewed Mar 30, 2024

View reviewed changes

src/components/VideoPopoverMenu/index.js Show resolved Hide resolved

parasharrajat mentioned this pull request Apr 15, 2024

[HOLD for payment 2024-04-15] [$500] Attachments - Next video starts playing when change Playback speed #38831

Closed

6 tasks

rayane-djouah reviewed May 3, 2024

View reviewed changes

rayane-djouah mentioned this pull request May 3, 2024

[HOLD for payment 2024-05-09] [$250] Incorrect video downloaded #40647

Closed

6 tasks

rushatgabhane reviewed May 13, 2024

View reviewed changes

rushatgabhane mentioned this pull request May 13, 2024

[Hold for payment 2024-04-29] [$500] Video - Console error shows up when playing video #39253

Closed

6 tasks

bernhardoj mentioned this pull request May 28, 2024

Fix blank preview when opened URL of deleted file #42680

Merged

50 tasks

s77rt reviewed Jun 3, 2024

View reviewed changes

s77rt mentioned this pull request Jun 3, 2024

[HOLD for payment 2024-06-06] [$250] Attachment - Blank preview when opened URL of deleted file #42438

Closed

6 tasks

hungvu193 reviewed Jun 4, 2024

View reviewed changes

hungvu193 mentioned this pull request Jun 4, 2024

[HOLD for payment 2024-06-03] [$250] Playback speed is not displayed correctly in video player #40646

Closed

6 tasks

allroundexperts reviewed Aug 11, 2024

View reviewed changes

allroundexperts mentioned this pull request Aug 11, 2024

[$250] Attachment - Wrong video playback speed is highlighted #42425

Closed

6 tasks

ikevin127 reviewed Sep 5, 2024

View reviewed changes

ikevin127 mentioned this pull request Sep 5, 2024

[HOLD for Payment 2024-09-06][$250] mWeb - Video - In welcome video, all playback speed options is not shown in normal mode #47205

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Video player #30829

Video player #30829

Skalakid commented Nov 3, 2023 •

edited by francoisl

Loading

OSBotify commented Feb 26, 2024

jjcoffee commented Mar 5, 2024

situchan Mar 6, 2024

parasharrajat Mar 13, 2024

alitoshmatov Mar 17, 2024 •

edited

Loading

eVoloshchak Mar 19, 2024

ishpaul777 commented Apr 7, 2024 •

edited

Loading

rayane-djouah May 3, 2024

rushatgabhane May 13, 2024

s77rt Jun 3, 2024

hungvu193 Jun 4, 2024

allroundexperts Aug 11, 2024

ikevin127 Sep 5, 2024

Video player #30829

Video player #30829

Conversation

Skalakid commented Nov 3, 2023 • edited by francoisl Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

OSBotify commented Feb 26, 2024

jjcoffee commented Mar 5, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alitoshmatov Mar 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ishpaul777 commented Apr 7, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Skalakid commented Nov 3, 2023 •

edited by francoisl

Loading

alitoshmatov Mar 17, 2024 •

edited

Loading

ishpaul777 commented Apr 7, 2024 •

edited

Loading