Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e tests #39238

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -10,14 +10,16 @@
const AUTOSCROLL_TO_TOP_THRESHOLD = 128;

let localViewableItems: ViewToken[];
const getViewableItems = () => localViewableItems;
const getViewableItems = () => console.log(787878798792) || localViewableItems;

Check failure on line 13 in src/components/InvertedFlatList/BaseInvertedFlatList/index.e2e.tsx

View workflow job for this annotation

GitHub Actions / typecheck

An expression of type 'void' cannot be tested for truthiness.

Check failure on line 13 in src/components/InvertedFlatList/BaseInvertedFlatList/index.e2e.tsx

View workflow job for this annotation

GitHub Actions / Run ESLint

Unexpected console statement

function BaseInvertedFlatListE2e(props: BaseInvertedFlatListProps, ref: React.ForwardedRef<FlatList<ReportAction>>) {
const {shouldEnableAutoScrollToTopThreshold, ...rest} = props;
console.log("BaseInvertedFlatListE2e");

Check failure on line 17 in src/components/InvertedFlatList/BaseInvertedFlatList/index.e2e.tsx

View workflow job for this annotation

GitHub Actions / Run ESLint

Unexpected console statement

const handleViewableItemsChanged = useMemo(
() =>
({viewableItems}: {viewableItems: ViewToken[]}) => {
console.log("handleViewableItemsChanged", {viewableItems});

Check failure on line 22 in src/components/InvertedFlatList/BaseInvertedFlatList/index.e2e.tsx

View workflow job for this annotation

GitHub Actions / Run ESLint

Unexpected console statement
localViewableItems = viewableItems;
},
[],
Expand Down
4 changes: 3 additions & 1 deletion src/libs/E2E/tests/linkingTest.e2e.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@
const linkedReportID = getConfigValueOrThrow('linkedReportID', config);
const linkedReportActionID = getConfigValueOrThrow('linkedReportActionID', config);

console.log({linkedReportActionID});

Check failure on line 21 in src/libs/E2E/tests/linkingTest.e2e.ts

View workflow job for this annotation

GitHub Actions / Run ESLint

Unexpected console statement

E2ELogin().then((neededLogin) => {
if (neededLogin) {
return waitForAppLoaded().then(() => E2EClient.submitTestDone());
Expand Down Expand Up @@ -59,7 +61,7 @@
console.debug('[E2E] Error while submitting test results:', err);
});
} else {
console.debug('[E2E] Message verification failed');
console.debug('[E2E] Message verification failed', res, linkedReportActionID);
}
}, 3000);
}
Expand Down
12 changes: 6 additions & 6 deletions tests/e2e/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,14 @@
* @type {Object.<string, TestConfig>}
*/
TESTS_CONFIG: {
[TEST_NAMES.AppStartTime]: {
/*[TEST_NAMES.AppStartTime]: {

Check failure on line 69 in tests/e2e/config.ts

View workflow job for this annotation

GitHub Actions / Run ESLint

Expected exception block, space or tab after '/*' in comment

Check failure on line 69 in tests/e2e/config.ts

View workflow job for this annotation

GitHub Actions / Run ESLint

Expected space or tab before '*/' in comment
name: TEST_NAMES.AppStartTime,

// ... any additional config you might need
},
[TEST_NAMES.OpenSearchPage]: {
},*/
/*[TEST_NAMES.OpenSearchPage]: {

Check failure on line 74 in tests/e2e/config.ts

View workflow job for this annotation

GitHub Actions / Run ESLint

Expected exception block, space or tab after '/*' in comment

Check failure on line 74 in tests/e2e/config.ts

View workflow job for this annotation

GitHub Actions / Run ESLint

Expected space or tab before '*/' in comment
name: TEST_NAMES.OpenSearchPage,
},
},*/
// TODO: Fix text and enable again
// [TEST_NAMES.ReportTyping]: {
// name: TEST_NAMES.ReportTyping,
Expand All @@ -83,11 +83,11 @@
// // Crowded Policy (Do Not Delete) Report, has a input bar available:
// reportID: '8268282951170052',
// },
[TEST_NAMES.ChatOpening]: {
/*[TEST_NAMES.ChatOpening]: {

Check failure on line 86 in tests/e2e/config.ts

View workflow job for this annotation

GitHub Actions / Run ESLint

Expected exception block, space or tab after '/*' in comment

Check failure on line 86 in tests/e2e/config.ts

View workflow job for this annotation

GitHub Actions / Run ESLint

Expected space or tab before '*/' in comment
name: TEST_NAMES.ChatOpening,
// #announce Chat with many messages
reportID: '5421294415618529',
},
},*/
[TEST_NAMES.Linking]: {
name: TEST_NAMES.Linking,
reportScreen: {
Expand Down
Loading