uncaught exception error when uploading a video #38720 #40132

serhii1030 · 2024-04-11T16:56:40Z

Details

Fix console error after closing attachment modal and fix error on downloading and changing playback speed.

Fixed Issues

$ #38720
PROPOSAL: #38720 (comment)

Tests

.

Go to any chat
Press + button and select Add attachment in the menu.
Upload a video.
Press play on uploaded video.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

macos.chrome.mp4

MacOS: Desktop

macos.desktop.mp4

melvin-bot · 2024-04-11T16:56:45Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2024-04-11T16:56:53Z

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

serhii1030 · 2024-04-11T23:12:59Z

I have read the CLA Document and I hereby sign the CLA

s77rt · 2024-04-12T06:50:28Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

@@ -172,12 +176,23 @@ function BaseVideoPlayer({
        });
    }, [currentVideoPlayerRef, handleFullscreenUpdate, handlePlaybackStatusUpdate]);

+    useLayoutEffect(() => {


use useEffect

If we use useEffect, we can't get the value of videoPlayerRef because it is called after unmount.
So I used useLayoutEffect.

I don't see why the ref wouldn't be available. Looks we are missing something here. Checking the rest of the refs all are available e.g. videoPlayerElementParentRef and videoPlayerElementRef

I found that other refs are available in useEffect.
Only video ref is null.
I thought there is code part to reset videoPlayerRef, but I couldn't find it.
I've test with other ref videoPlayerRef1, but couldn't get value in useEffect either.
It seems it is relative with Video component.

Sorry I forgot to reply here. Can you please add a comment explaining that (why we can't use useEffect) and also complete the checklist (screenshots)

Could you please check this?
facebook/react#20875
I think this github issue gives us an answer.

Makes sense but I meant to write a code comment, add the blog link for future ref https://legacy.reactjs.org/blog/2020/08/10/react-v17-rc.html#effect-cleanup-timing

s77rt · 2024-04-12T06:50:51Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

+            if(!shouldUseSharedVideoElement && (isUploading || videoPlayerRef.current === currentVideoPlayerRef.current)) {
+                currentVideoPlayerRef.current = null;
+            }


Prefer early return. Please run npm run lint

Ok, thank you.

s77rt · 2024-04-12T06:51:19Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

@@ -172,12 +176,23 @@ function BaseVideoPlayer({
        });
    }, [currentVideoPlayerRef, handleFullscreenUpdate, handlePlaybackStatusUpdate]);

+    useLayoutEffect(() => {
+        return () => {
+            if(!shouldUseSharedVideoElement && (isUploading || videoPlayerRef.current === currentVideoPlayerRef.current)) {


What case is the isUploading check needed for?

isUploading check is not needed. Thank you.

s77rt · 2024-04-12T07:00:53Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

+        if(currentVideoPlayerRef.current) {
+            pauseVideo();
+        }


Why is that needed?

Currently, previous playing video is paused when playing new video.
When playing new video, below two functions are called in order and playing video is paused.

pause video

App/src/components/VideoPlayerContexts/PlaybackContext.tsx

Lines 41 to 49 in c7d6926

const updateCurrentlyPlayingURL = useCallback(

(url: string | null) => {

if (currentlyPlayingURL && url !== currentlyPlayingURL) {

pauseVideo();

}

setCurrentlyPlayingURL(url);

},

[currentlyPlayingURL, pauseVideo],

);

update current ref

App/src/components/VideoPlayerContexts/PlaybackContext.tsx

Lines 51 to 62 in c7d6926

const shareVideoPlayerElements = useCallback(

(ref: VideoWithOnFullScreenUpdate | null, parent: View | HTMLDivElement | null, child: View | HTMLDivElement | null, isUploading: boolean) => {

currentVideoPlayerRef.current = ref;

setOriginalParent(parent);

setSharedElement(child);

// Prevents autoplay when uploading the attachment

if (!isUploading) {

playVideo();

}

},

[playVideo],

);

But when uploading, first function is called after current ref is updated because we set it below.

App/src/components/VideoPlayer/BaseVideoPlayer.tsx

Lines 180 to 181 in c7d6926

// If we are uploading a new video, we want to immediately set the video player ref.

currentVideoPlayerRef.current = videoPlayerRef.current;

And previous video is not paused. So I paused it before setting current ref.

s77rt · 2024-04-12T07:01:05Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

+        videoPlayerRef.current?.getStatusAsync().then((status) => {
+            if('rate' in status && status.rate) {
+                updatePlaybackSpeed(status.rate as PlaybackSpeed);
+            }
+        })


Same, what case is this fixing?

Assuming this test case.

Play Video1.

Then change playback speed to 0.25

Play Video2.

Then play Video1 again.

Check playback speed (three dot menu -> playback speed).

Before fix, Video1 is played in speed 0.25 but in menu it is set as 1(default value).

s77rt · 2024-04-12T07:06:17Z

Pressing the three dots button should not play the video

Screen.Recording.2024-04-12.at.8.02.04.AM.mov

s77rt · 2024-04-12T07:07:24Z

@KMichel1030 Please go over the checklist (missing tests, screenshots, etc.)

serhii1030 · 2024-04-12T08:51:59Z

@s77rt

Pressing the three dots button should not play the video

I'm working on this. Is it ok to add screenshots after fix?

serhii1030 · 2024-04-12T15:02:37Z

src/components/VideoPlayer/BaseVideoPlayer.tsx


    // update shared video elements
    useEffect(() => {
-        if (shouldUseSharedVideoElement || url !== currentlyPlayingURL || isFullScreenRef.current) {
+        if (shouldUseSharedVideoElement || url !== currentlyPlayingURL) {


@s77rt
Let's check this test case.

play video1.

play video2.

press fullscreen mode button of video1.

exit fullscreen mode with pressing esc key. (don't play video)

press play button of video1.

Before fix:
video2 is played.

This error is occurred because currentVideoPlayerRef is not set when enter fullscreen mode.
So I've deleted above condition.
Please let me know your suggestion.

serhii1030 · 2024-04-12T15:07:23Z

src/components/VideoPlayer/BaseVideoPlayer.tsx

            return;
        }
-        shareVideoPlayerElements(videoPlayerRef.current, videoPlayerElementParentRef.current, videoPlayerElementRef.current, isUploading);
-    }, [currentlyPlayingURL, shouldUseSharedVideoElement, shareVideoPlayerElements, url, isUploading, isFullScreenRef]);
+        shareVideoPlayerElements(videoPlayerRef.current, videoPlayerElementParentRef.current, videoPlayerElementRef.current, isUploading || isPopoverVisible);


In shareVideoPlayerElements function, video is not played if last parameter is true.
So I added isPopoverVisible to prevent auto play.

s77rt

Can you please revert all the changes that are not related to fixing the console error. The solutions for other problems feel like band-aid and I'd prefer to handle them separately

s77rt · 2024-04-14T09:21:34Z

Let's investigate this one #40132 (comment)

s77rt · 2024-04-18T15:28:22Z

@KMichel1030 Please add clear testing steps (the current steps are not enough to reproduce the bug)

s77rt · 2024-04-18T15:28:46Z

Also please add missing screenshots.
Edit: the bug is not reproducible on the rest of the platforms, so just add a screenshot that things are still working as expected

s77rt · 2024-04-18T16:18:13Z

Can you also run npm run prettier

s77rt · 2024-04-18T16:22:04Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

desktop.mov

blimpich

Looks great! Thank you @KMichel1030 for contributing!

blimpich · 2024-04-19T18:06:19Z

@KMichel1030 one note: in the future preferably don't force-push your changes. I tried to look at the commit history to better understand this comment and couldn't because that history had been overwritten.

Please let me know what other issues you found and I can make issues for them for you to fix 🙂

OSBotify · 2024-04-19T18:14:39Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-04-23T23:42:52Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

serhii1030 requested a review from a team as a code owner April 11, 2024 16:56

melvin-bot bot requested review from s77rt and removed request for a team April 11, 2024 16:56

s77rt suggested changes Apr 12, 2024

View reviewed changes

serhii1030 commented Apr 12, 2024

View reviewed changes

s77rt suggested changes Apr 14, 2024

View reviewed changes

fix issue

5431131

serhii1030 force-pushed the fix/issue-38720 branch from 6e7b491 to 5431131 Compare April 14, 2024 07:40

add comment

6c2c0a1

prettier

6cb3222

s77rt approved these changes Apr 19, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich April 19, 2024 14:50

blimpich approved these changes Apr 19, 2024

View reviewed changes

blimpich merged commit e0a43be into Expensify:main Apr 19, 2024
16 checks passed

github-actions bot mentioned this pull request Apr 22, 2024

Deploy Checklist: New Expensify 2024-04-22 #40702

Closed

95 tasks

bernhardoj mentioned this pull request Apr 26, 2024

[$250] Onboarding- After finishing "onboarding" and switching to DM, an error appears in the console #40458

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

uncaught exception error when uploading a video #38720 #40132

uncaught exception error when uploading a video #38720 #40132

serhii1030 commented Apr 11, 2024 •

edited

Loading

melvin-bot bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024 •

edited

Loading

serhii1030 commented Apr 11, 2024

s77rt Apr 12, 2024

serhii1030 Apr 12, 2024

s77rt Apr 14, 2024

serhii1030 Apr 14, 2024 •

edited

Loading

s77rt Apr 17, 2024

serhii1030 Apr 17, 2024

s77rt Apr 17, 2024

s77rt Apr 12, 2024

serhii1030 Apr 12, 2024

s77rt Apr 12, 2024

serhii1030 Apr 12, 2024

s77rt Apr 12, 2024

serhii1030 Apr 12, 2024

s77rt Apr 12, 2024

serhii1030 Apr 12, 2024

s77rt commented Apr 12, 2024

s77rt commented Apr 12, 2024

serhii1030 commented Apr 12, 2024

serhii1030 Apr 12, 2024

serhii1030 Apr 12, 2024

s77rt left a comment

s77rt commented Apr 14, 2024

s77rt commented Apr 18, 2024

s77rt commented Apr 18, 2024 •

edited

Loading

s77rt commented Apr 18, 2024

s77rt commented Apr 18, 2024 •

edited

Loading

blimpich left a comment

blimpich commented Apr 19, 2024

OSBotify commented Apr 19, 2024

OSBotify commented Apr 23, 2024

	const updateCurrentlyPlayingURL = useCallback(
	(url: string \| null) => {
	if (currentlyPlayingURL && url !== currentlyPlayingURL) {
	pauseVideo();
	}
	setCurrentlyPlayingURL(url);
	},
	[currentlyPlayingURL, pauseVideo],
	);

	const shareVideoPlayerElements = useCallback(
	(ref: VideoWithOnFullScreenUpdate \| null, parent: View \| HTMLDivElement \| null, child: View \| HTMLDivElement \| null, isUploading: boolean) => {
	currentVideoPlayerRef.current = ref;
	setOriginalParent(parent);
	setSharedElement(child);
	// Prevents autoplay when uploading the attachment
	if (!isUploading) {
	playVideo();
	}
	},
	[playVideo],
	);

	// If we are uploading a new video, we want to immediately set the video player ref.
	currentVideoPlayerRef.current = videoPlayerRef.current;

uncaught exception error when uploading a video #38720 #40132

uncaught exception error when uploading a video #38720 #40132

Conversation

serhii1030 commented Apr 11, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 11, 2024

github-actions bot commented Apr 11, 2024 • edited Loading

serhii1030 commented Apr 11, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

serhii1030 Apr 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt commented Apr 12, 2024

s77rt commented Apr 12, 2024

serhii1030 commented Apr 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

s77rt left a comment

Choose a reason for hiding this comment

s77rt commented Apr 14, 2024

s77rt commented Apr 18, 2024

s77rt commented Apr 18, 2024 • edited Loading

s77rt commented Apr 18, 2024

s77rt commented Apr 18, 2024 • edited Loading

Reviewer Checklist

Screenshots/Videos

blimpich left a comment

Choose a reason for hiding this comment

blimpich commented Apr 19, 2024

OSBotify commented Apr 19, 2024

OSBotify commented Apr 23, 2024

serhii1030 commented Apr 11, 2024 •

edited

Loading

github-actions bot commented Apr 11, 2024 •

edited

Loading

serhii1030 Apr 14, 2024 •

edited

Loading

s77rt commented Apr 18, 2024 •

edited

Loading

s77rt commented Apr 18, 2024 •

edited

Loading