Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gracefully handle missing test cases between two apps #40689

Merged

Conversation

kirillzyusko
Copy link
Contributor

@kirillzyusko kirillzyusko commented Apr 22, 2024

Details

Sometimes we may add new test case or rename a test. In this case the e2e pipeline will be broken, because we'll try to run not existing tests on baseline app version (which leads to timeout error now, because test is not getting executed and after 300s app gets killed by our test runner).

In this PR I fixed this problem by gracefully handling the case - when we receive non critical error (currently this is the only one error indicating that test is not found) we'll call forceTestCompletion on a server side to clearly indicate that test finished its execution and we can go further.

After these change in compareResults we'll have next test data:

Delta VS Main (report)
  {
  main: {
    'App start nativeLaunch': [
      51, 45, 48, 43,
      54, 45, 42, 53
    ],
    'App start nativeLaunchEnd_To_appCreationStart': [
      61, 38, 48, 41,
      37, 50, 36, 39
    ],
    'App start appCreation': [
      73, 56, 62, 66,
      51, 62, 68, 67
    ],
    'App start runJsBundle': [
      359, 309, 313,
      345, 313, 350,
      341, 321
    ],
    'App start appCreationEnd_To_contentAppeared': [
      455, 404, 422,
      445, 416, 451,
      438, 425
    ],
    'App start contentAppeared_To_screenTTI': [
      926.1352340001613,
      808.8870689999312,
      882.0101989991963,
      824.3700229991227,
      750.9790739994496,
      974.3169669993222,
      760.4869720004499,
      911.4533629994839
    ],
    'App start TTI': [
      1566.1352340001613,
      1351.8870689999312,
      1462.0101989991963,
      1419.3700229991227,
      1308.9790739994496,
      1582.3169669993222,
      1344.48697200045,
      1495.453362999484
    ],
    'App start regularAppStart': [
      0.018432000651955605,
      0.01855500042438507,
      0.016927000135183334,
      0.0174150001257658,
      0.018880000337958336,
      0.019245998933911324,
      0.020711999386548996,
      0.021362001076340675
    ],
    'Chat opening': [
      50.53926599957049,
      18.8972570002079,
      19.913980999961495,
      26.739176001399755,
      21.597574999555945,
      26.9226890001446,
      24.792521001771092,
      22.543579000979662,
      22.014240998774767
    ],
    'Chat TTI': [
      4417.695436000824,
      253.23368300125003,
      302.44303400069475,
      336.76261400058866,
      362.21338000148535,
      368.44978800043464,
      405.98950199969113,
      387.2469490002841,
      391.062663000077
    ]
  }
}
{
  delta: {
    'App start nativeLaunch': [
      40, 48, 47, 46,
      55, 50, 48, 49
    ],
    'App start nativeLaunchEnd_To_appCreationStart': [
      50, 43, 46, 45,
      55, 41, 38, 44
    ],
    'App start contentAppeared_To_screenTTI': [
      849.8249329999089,
      840.6559500005096,
      846.7410339992493,
      847.9091679994017,
      858.9504289999604,
      841.7195960003883,
      907.3378030005842,
      1017.2439729999751
    ],
    'App start appCreation': [
      58, 66, 55, 58,
      56, 63, 64, 60
    ],
    'App start runJsBundle': [
      308, 345, 350,
      307, 329, 357,
      341, 343
    ],
    'App start appCreationEnd_To_contentAppeared': [
      430, 452, 449,
      411, 427, 457,
      446, 449
    ],
    'App start TTI': [
      1427.824932999909,
      1449.6559500005096,
      1443.7410339992493,
      1407.9091679994017,
      1451.9504289999604,
      1452.7195960003883,
      1503.3378030005842,
      1619.243972999975
    ],
    'App start regularAppStart': [
      0.018636999651789665,
      0.017090000212192535,
      0.01757900044322014,
      0.017130998894572258,
      0.017740000039339066,
      0.020262999460101128,
      0.017211999744176865,
      0.020183000713586807
    ],
    'Open Chat Finder Page TTI': [
      788.0697019994259,
      1149.6198730003089,
      1014.984579000622,
      1017.9701340012252,
      1177.9677740000188,
      1162.9797769989818,
      1397.7467859983444,
      1065.965983999893,
      1155.0807300005108
    ],
    'Chat opening': [
      58.11433899961412,
      28.28991699963808,
      19.28430199995637,
      21.84948700107634,
      25.501506000757217,
      22.457032000645995,
      27.008464001119137,
      22.900961000472307,
      21.812541000545025
    ],
    'Chat TTI': [
      3671.6196299996227,
      308.547729998827,
      299.43794699944556,
      308.8984789997339,
      348.2585049998015,
      296.8203129991889,
      332.655232001096,
      352.6728520002216,
      322.54195199906826
    ]
  }
}

Fixed Issues

$ #40544
PROPOSAL: N/A

Tests

  • run e2e pipeline on CI (no new release is needed, it should work in current setup);

Offline tests

N/A

QA Steps

QA can skip testing this PR because it's e2e stuff.

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

image

Android: mWeb Chrome

E2E tests are available only on Android.

iOS: Native

E2E tests are available only on Android.

iOS: mWeb Safari

E2E tests are available only on Android.

MacOS: Chrome / Safari

E2E tests are available only on Android.

MacOS: Desktop

E2E tests are available only on Android.

@kirillzyusko kirillzyusko requested a review from a team as a code owner April 22, 2024 12:49
@melvin-bot melvin-bot bot requested review from sobitneupane and removed request for a team April 22, 2024 12:49
Copy link

melvin-bot bot commented Apr 22, 2024

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@@ -66,6 +66,7 @@ E2EClient.getTestConfig()
console.error(`[E2E] Test '${config.name}' not found`);
// instead of throwing, report the error to the server, which is better for DX
return E2EClient.submitTestResults({
branch: Config.E2E_BRANCH,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It resolves a problem where we see undefined in message like

[LISTENER] Test 'Open chat finder page TTI' on 'undefined' measured 0

@kirillzyusko kirillzyusko force-pushed the fix/e2e-tests-handle-new-test-cases branch from 898bd17 to 2fcd8df Compare April 22, 2024 13:23
@danieldoglas danieldoglas requested review from danieldoglas and removed request for sobitneupane April 22, 2024 14:18
@danieldoglas
Copy link
Contributor

Reviewing internally. Looks like tests are passing when testing with the workflow from this branch: https://github.com/Expensify/App/actions/runs/8784801993

@danieldoglas
Copy link
Contributor

danieldoglas commented Apr 22, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop

@danieldoglas danieldoglas merged commit 12046fa into Expensify:main Apr 22, 2024
16 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants