-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gracefully handle missing test cases between two apps #40689
fix: gracefully handle missing test cases between two apps #40689
Conversation
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@@ -66,6 +66,7 @@ E2EClient.getTestConfig() | |||
console.error(`[E2E] Test '${config.name}' not found`); | |||
// instead of throwing, report the error to the server, which is better for DX | |||
return E2EClient.submitTestResults({ | |||
branch: Config.E2E_BRANCH, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It resolves a problem where we see undefined
in message like
[LISTENER] Test 'Open chat finder page TTI' on 'undefined' measured 0
898bd17
to
2fcd8df
Compare
Reviewing internally. Looks like tests are passing when testing with the workflow from this branch: https://github.com/Expensify/App/actions/runs/8784801993 |
Reviewer Checklist
Screenshots/VideosAndroid: NativeAndroid: mWeb ChromeiOS: NativeiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to production by https://github.com/mountiny in version: 1.4.64-6 🚀
|
Details
Sometimes we may add new test case or rename a test. In this case the e2e pipeline will be broken, because we'll try to run not existing tests on baseline app version (which leads to timeout error now, because test is not getting executed and after 300s app gets killed by our test runner).
In this PR I fixed this problem by gracefully handling the case - when we receive non critical error (currently this is the only one error indicating that test is not found) we'll call
forceTestCompletion
on a server side to clearly indicate that test finished its execution and we can go further.After these change in
compareResults
we'll have next test data:Delta VS Main (report)
Fixed Issues
$ #40544
PROPOSAL: N/A
Tests
Offline tests
N/A
QA Steps
QA can skip testing this PR because it's e2e stuff.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodSTYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)Design
label and/or tagged@Expensify/design
so the design team can review the changes.ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
E2E tests are available only on Android.
iOS: Native
E2E tests are available only on Android.
iOS: mWeb Safari
E2E tests are available only on Android.
MacOS: Chrome / Safari
E2E tests are available only on Android.
MacOS: Desktop
E2E tests are available only on Android.