Playback speed is not displayed correctly in video player #40646 #41055

serhii1030 · 2024-04-26T02:50:55Z

Details

Fixed Issues

$ #40646
PROPOSAL: #40646 (comment)

Tests

For MacOS: Chrome / Safari & MacOS: Desktop

Upload two videos(Video1, Video2).
Play Video1.
Play Video2.
Change playback speed of Video2 to 2.
Then change playback speed of Video1 to 0.25 (or any other)
Check if playback speed of Video2 is 2.
Play Video1 and check if speed is 0.25.

Other platforms

Upload two videos(Video1, Video2).
Play Video1 and change speed to 0.25(or any other)
Play Video2 and check that speed is 1.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

bandicam.2024-05-15.10-22-56-062.mp4

iOS: mWeb Safari

bandicam.2024-05-15.12-08-32-903.mp4

MacOS: Chrome / Safari

chrome.mp4

MacOS: Desktop

bandicam.2024-04-28.06-49-58-948.mp4

melvin-bot · 2024-04-26T02:51:00Z

@hungvu193 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hungvu193 · 2024-04-26T03:00:11Z

src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

@@ -18,13 +19,14 @@ function VideoPopoverMenuContextProvider({children}: ChildrenProps) {
    const [currentPlaybackSpeed, setCurrentPlaybackSpeed] = useState<PlaybackSpeed>(CONST.VIDEO_PLAYER.PLAYBACK_SPEEDS[2]);
    const {isOffline} = useNetwork();
    const isLocalFile = currentlyPlayingURL && CONST.ATTACHMENT_LOCAL_URL_PREFIX.some((prefix) => currentlyPlayingURL.startsWith(prefix));
+    const playerRef = useRef<VideoWithOnFullScreenUpdate | null>(null);


Can we give it a more meaningful name? IE: videoPopoverMenuRef

Suggested change

const playerRef = useRef<VideoWithOnFullScreenUpdate | null>(null);

const videoPopoverMenuPlayerRef = useRef<VideoWithOnFullScreenUpdate | null>(null);

hungvu193 · 2024-04-26T06:36:40Z

@KMichel1030 I recommend that you should only mark PR ready when you've completed all the video and checklist.

hungvu193 · 2024-05-01T02:13:44Z

Any update here please? @KMichel1030

hungvu193 · 2024-05-02T02:54:56Z

We have conflicts here @KMichel1030

serhii1030 · 2024-05-02T14:26:27Z

@hungvu193
Sorry for late reply.
The conflict has occurred because of this issue.
I will resolve conflict asap.

hungvu193 · 2024-05-03T06:25:02Z

Is there any chance that you can complete the PR author checklist today? It's been a week though

hungvu193 · 2024-05-06T16:52:05Z

Bump @KMichel1030, any update please?

serhii1030 · 2024-05-06T22:06:25Z

@hungvu193
Sorry for delay.
Currently, I have problem with my dev env. I tried to build other platforms but it's difficult to find problem.
I'm still working to build other platforms.
But I'm wondering if there's any other way we can proceed. Actually, I can't sure how long it will take.
Thank you for your understanding.

hungvu193 · 2024-05-07T01:17:50Z

Did you try npm run clean?

serhii1030 · 2024-05-07T05:23:33Z

Sorry, I've tried npm run clean but still have this error.

hungvu193 · 2024-05-07T06:14:15Z

can you please post the full logs? Also if you can not build ios, can you build android? I only saw you complete the record for desktop and mac/chrome

serhii1030 · 2024-05-07T10:58:07Z

@hungvu193
I've run web & desktop versions but I have trouble with other versions.
Regarding android, I haven't built it even once.
I'm sorry but you know, I'm a new contributor and this is first time to work on other platforms.
I'm trying hard but I'm wondering if we can proceed with your check. Of course, only if it is not violation of contributing rule.
cc: @blimpich

hungvu193 · 2024-05-07T11:00:40Z

Wdym other versions? Even mWeb Safari and mWeb Android chrome? Did you follow the guide for local development here?
https://github.com/Expensify/App/blob/main/README.md#local-development

serhii1030 · 2024-05-07T11:06:53Z

Of course, I've followed guide. I built ios version once, but then error persists.
I'm trying for over a week but can't find solution. I have problem on ios so I can't afford to build other versions.

hungvu193 · 2024-05-07T11:08:28Z

Please post the full logs to expensify open source so we can help you. I'll verify the changes in the mean time.

hungvu193 · 2024-05-08T03:09:16Z

Can you please merge with main? @KMichel1030

hungvu193 · 2024-05-08T04:00:16Z

Please see the video, I don't think it's working for IOS. I got an infinite loop render also

Screen.Recording.2024-05-08.at.10.57.47.mov

serhii1030 · 2024-05-08T05:24:14Z

Ok, I will check. Thank you.

serhii1030 · 2024-05-08T06:22:28Z

merged main branch

hungvu193 · 2024-05-09T03:50:52Z

Could you please let me know if it is working on other platforms? Doesn't work on only ios? It will be helpful if you post test video for me. I can't sure what the problem is.

The problem will be with small screen, since we will use attachment modal for them to display (wrap) the video player instead of using VideoPlayer itself directly.

hungvu193 · 2024-05-14T03:12:42Z

Friendly bump here @KMichel1030

serhii1030 · 2024-05-14T13:34:35Z

@hungvu193
I'm very sorry but I still working on it. I will make it run in a few days.

The problem will be with small screen, since we will use attachment modal for them to display (wrap) the video player instead of using VideoPlayer itself directly.

I've tested it with smartphone size in web and it's working properly. So it seems it's not problem with small screen.
Could you please test again and let me know test steps for error case? Thank you for understanding.

bandicam.2024-05-14.16-32-19-619.mp4

hungvu193 · 2024-05-14T13:47:03Z

Cool. Thanks for letting me know. Can you please merge main again? I'll take another few tests

serhii1030 · 2024-05-14T13:59:51Z

@hungvu193
Thank you. I've merged main branch.

serhii1030 · 2024-05-15T07:34:23Z

Hi, @hungvu193
I've checked on ios and confirmed it's working properly.

hungvu193 · 2024-05-15T07:35:28Z

Cool, please complete the author checklist while I'm checking it rn

hungvu193 · 2024-05-15T08:08:34Z

Feels like server is down, I can't upload the video, I'll take another test later today

serhii1030 · 2024-05-15T08:11:41Z

@hungvu193
Thank you.
BTW, I try to test on ios safari but so this error. Could you please let me know the solution? I tried several solutions but failed.

hungvu193 · 2024-05-15T08:14:19Z

Make sure you setup https: https://github.com/Expensify/App?tab=readme-ov-file#configuring-https
Also can you try with https://127.0.0.1:8082 instead? Also make sure your server is running at port 8082 (npm run web)

serhii1030 · 2024-05-15T08:18:54Z

@hungvu193
Thank you, I could open page with https://127.0.0.1:8082. I will build android version asap.

hungvu193 · 2024-05-15T08:26:52Z

Can you merge main again? MenuItem is broken on our branch

serhii1030 · 2024-05-15T08:42:08Z

@hungvu193
I've merged main branch. But I can't sure that the problem is.
Could you please tell me more about MenuItem crash?

hungvu193 · 2024-05-15T08:45:50Z

@hungvu193 I've merged main branch. But I can't sure that the problem is. Could you please tell me more about MenuItem crash?

No worries, it's not related to this PR

hungvu193 · 2024-05-15T09:01:31Z

So I got this one on iOS, open any video, change the speed, close the modal and open that video again, now the speed is reset to 1. But I think that's fine. I didn't find any other problem so far. I'll complete checklist in a while

hungvu193 · 2024-05-15T09:19:24Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Screen.Recording.2024-05-15.at.16.19.00.mov

Android: mWeb Chrome

Screen.Recording.2024-05-15.at.16.15.00.mov

iOS: Native

Screen.Recording.2024-05-15.at.15.52.16.mp4

iOS: mWeb Safari

Screen.Recording.2024-05-15.at.16.11.12.mov

MacOS: Chrome / Safari

Screen.Recording.2024-05-15.at.16.12.17.mov

MacOS: Desktop

Screen.Recording.2024-05-15.at.16.09.36.mov

hungvu193

LGTM!

blimpich

LGTM

OSBotify · 2024-05-15T17:46:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2024-05-23T00:39:09Z

🚀 Deployed to staging by https://github.com/blimpich in version: 1.4.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2024-05-27T14:02:17Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.4.75-1 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

situchan · 2024-08-21T15:24:55Z

src/components/VideoPlayerContexts/VideoPopoverMenuContext.tsx

@@ -24,9 +24,9 @@ function VideoPopoverMenuContextProvider({children}: ChildrenProps) {
    const updatePlaybackSpeed = useCallback(
        (speed: PlaybackSpeed) => {
            setCurrentPlaybackSpeed(speed);
-            currentVideoPlayerRef.current?.setStatusAsync?.({rate: speed});
+            videoPopoverMenuPlayerRef.current?.setStatusAsync?.({rate: speed});


There was regression from this change.
More details: #42519 (comment)

serhii1030 added 2 commits April 25, 2024 04:19

fix playback speed error

ed94034

Merge branch 'main' into fix/issue-40646

cf711f1

serhii1030 requested a review from a team as a code owner April 26, 2024 02:50

melvin-bot bot requested review from hungvu193 and removed request for a team April 26, 2024 02:50

hungvu193 suggested changes Apr 26, 2024

View reviewed changes

update ref name

29a23c2

serhii1030 force-pushed the fix/issue-40646 branch from 9143b89 to 29a23c2 Compare April 26, 2024 15:24

prettier

daaf9fa

resolve conflict

ee15197

merge main

95baded

This comment was marked as resolved.

Sign in to view

Merge branch 'main' into fix/issue-40646

9b16375

Merge branch 'main' into fix/issue-40646

50e16d1

hungvu193 approved these changes May 15, 2024

View reviewed changes

melvin-bot bot requested a review from blimpich May 15, 2024 09:19

blimpich approved these changes May 15, 2024

View reviewed changes

blimpich merged commit b826235 into Expensify:main May 15, 2024
17 checks passed

github-actions bot mentioned this pull request May 22, 2024

Deploy Checklist: New Expensify 2024-05-22 #42496

Closed

45 tasks

melvin-bot bot mentioned this pull request May 27, 2024

[HOLD for payment 2024-06-03] [$250] Playback speed is not displayed correctly in video player #40646

Closed

6 tasks

jainilparikh mentioned this pull request Jun 1, 2024

[HOLD for payment 2024-08-02] [$250] Video - Change in playback speed is not reflected in thread report #42519

Closed

6 tasks

situchan reviewed Aug 21, 2024

View reviewed changes

	const playerRef = useRef<VideoWithOnFullScreenUpdate \| null>(null);
	const videoPopoverMenuPlayerRef = useRef<VideoWithOnFullScreenUpdate \| null>(null);

Playback speed is not displayed correctly in video player #40646 #41055

Playback speed is not displayed correctly in video player #40646 #41055

Conversation

serhii1030 commented Apr 26, 2024 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Apr 26, 2024

hungvu193 Apr 26, 2024

Choose a reason for hiding this comment

hungvu193 commented Apr 26, 2024

hungvu193 commented May 1, 2024

hungvu193 commented May 2, 2024

serhii1030 commented May 2, 2024

hungvu193 commented May 3, 2024 • edited Loading

hungvu193 commented May 6, 2024

serhii1030 commented May 6, 2024

hungvu193 commented May 7, 2024

serhii1030 commented May 7, 2024

hungvu193 commented May 7, 2024 • edited Loading

serhii1030 commented May 7, 2024

hungvu193 commented May 7, 2024

serhii1030 commented May 7, 2024

hungvu193 commented May 7, 2024

hungvu193 commented May 8, 2024

hungvu193 commented May 8, 2024 • edited Loading

serhii1030 commented May 8, 2024

serhii1030 commented May 8, 2024

This comment was marked as resolved.

hungvu193 commented May 9, 2024 • edited Loading

hungvu193 commented May 14, 2024

serhii1030 commented May 14, 2024

hungvu193 commented May 14, 2024

serhii1030 commented May 14, 2024

serhii1030 commented May 15, 2024

hungvu193 commented May 15, 2024

hungvu193 commented May 15, 2024

serhii1030 commented May 15, 2024

hungvu193 commented May 15, 2024 • edited Loading

serhii1030 commented May 15, 2024

hungvu193 commented May 15, 2024

serhii1030 commented May 15, 2024

hungvu193 commented May 15, 2024

hungvu193 commented May 15, 2024

hungvu193 commented May 15, 2024

Reviewer Checklist

Screenshots/Videos

hungvu193 left a comment

Choose a reason for hiding this comment

blimpich left a comment

Choose a reason for hiding this comment

OSBotify commented May 15, 2024

OSBotify commented May 23, 2024

OSBotify commented May 27, 2024

situchan Aug 21, 2024

Choose a reason for hiding this comment

serhii1030 commented Apr 26, 2024 •

edited

Loading

hungvu193 commented May 3, 2024 •

edited

Loading

hungvu193 commented May 7, 2024 •

edited

Loading

hungvu193 commented May 8, 2024 •

edited

Loading

hungvu193 commented May 9, 2024 •

edited

Loading

hungvu193 commented May 15, 2024 •

edited

Loading