Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use transaction distanceUnit to prevent retroactive changes #50001

Merged
merged 34 commits into from
Oct 17, 2024
Merged

Use transaction distanceUnit to prevent retroactive changes #50001

merged 34 commits into from
Oct 17, 2024
+137 −70

Commits on Oct 1, 2024

  1. Use transaction distanceUnit to prevent retroactive changes

    @neil-marcellini
    neil-marcellini committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    b9d9f6b View commit details
    Browse the repository at this point in the history

  2. Display rate with transaction's distance unit

    @neil-marcellini
    neil-marcellini committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    3cedd46 View commit details
    Browse the repository at this point in the history

  3. Prompt with both units for when transaction unit doesn't match policy

    @neil-marcellini
    neil-marcellini committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    d6c88de View commit details
    Browse the repository at this point in the history

  4. WIP optimistically set distanceUnit

    @neil-marcellini
    neil-marcellini committed Oct 1, 2024
    Configuration menu
    Copy the full SHA
    778dd23 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Pass existing transaction in all distance cases

    @neil-marcellini
    neil-marcellini committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    540f11a View commit details
    Browse the repository at this point in the history

  2. Optimistically update to current distance unit when editing

    @neil-marcellini
    neil-marcellini committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    3961d4c View commit details
    Browse the repository at this point in the history

  3. Prettify

    @neil-marcellini
    neil-marcellini committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    4520fe3 View commit details
    Browse the repository at this point in the history

Commits on Oct 7, 2024

  1. Merge branch 'main' into neil-distanceUnit

    @neil-marcellini
    neil-marcellini committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    7579b73 View commit details
    Browse the repository at this point in the history

  2. Remove unused types

    @neil-marcellini
    neil-marcellini committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    9936790 View commit details
    Browse the repository at this point in the history

  3. Missed a spot

    @neil-marcellini
    neil-marcellini committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    56c96fb View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Merge branch 'main' into neil-distanceUnit

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    ebff76e View commit details
    Browse the repository at this point in the history

  2. WIP use util to get transaction distance rate

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    9a06cfe View commit details
    Browse the repository at this point in the history

  3. Util to get updated distance unit

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    7982c26 View commit details
    Browse the repository at this point in the history

  4. Use get rate util in another spot

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5c43231 View commit details
    Browse the repository at this point in the history

  5. Simplify using lodashSet

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    e07a837 View commit details
    Browse the repository at this point in the history

  6. WIP convert distance to new rate unit

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    18657fd View commit details
    Browse the repository at this point in the history

  7. Refactor and fix getting updated distance unit

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1703edb View commit details
    Browse the repository at this point in the history

  8. Fix distance conversion with parenthesis

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    466990b View commit details
    Browse the repository at this point in the history

  9. Set distance pending when converted to new rate unit

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    da47219 View commit details
    Browse the repository at this point in the history

  10. Clear pendingFields that aren't part of transactionChanges

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    8f10f77 View commit details
    Browse the repository at this point in the history

  11. Fix lint

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    5bd5c3a View commit details
    Browse the repository at this point in the history

  12. Fix getting mileageRate.rate

    @neil-marcellini
    neil-marcellini committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    a307c8d View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Merge branch 'main' into neil-distanceUnit

    @neil-marcellini
    neil-marcellini committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    99e9170 View commit details
    Browse the repository at this point in the history

  2. Ensure currency is always set

    @neil-marcellini
    neil-marcellini committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    aded5c2 View commit details
    Browse the repository at this point in the history

  3. Use stored P2P rate for existing transactions

    @neil-marcellini
    neil-marcellini committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    7a9d0ea View commit details
    Browse the repository at this point in the history

  4. Explain why the update distance unit should come from the rate

    @neil-marcellini
    neil-marcellini committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1e87ca3 View commit details
    Browse the repository at this point in the history

  5. Apply feedback to clean things up

    @neil-marcellini
    neil-marcellini committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    ce80ef1 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Merge branch 'main' into neil-distanceUnit

    @neil-marcellini
    neil-marcellini committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    817266b View commit details
    Browse the repository at this point in the history

  2. Fix some ts errors

    @neil-marcellini
    neil-marcellini committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a2f0074 View commit details
    Browse the repository at this point in the history

  3. Fix if somehow mileageRate is undefined

    @neil-marcellini
    neil-marcellini committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    00eeb4a View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Merge branch 'main' into neil-distanceUnit

    @neil-marcellini
    neil-marcellini committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    5b12592 View commit details
    Browse the repository at this point in the history

  2. Ensure policy is defined for optimistic distance unit

    @neil-marcellini
    neil-marcellini committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    01e652a View commit details
    Browse the repository at this point in the history

  3. Fix ts, missing param

    @neil-marcellini
    neil-marcellini committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    611ad8b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2024

  1. Merge branch 'main' into neil-distanceUnit

    @neil-marcellini
    neil-marcellini committed Oct 17, 2024
    Configuration menu
    Copy the full SHA
    f0ec762 View commit details
    Browse the repository at this point in the history